openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(1 comment)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 31503 \u003c31503@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31503\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31503\u003e replied on the change"}
This commit is contained in:
Gerrit User 31503 2023-10-20 07:35:43 +00:00 committed by Gerrit Code Review
parent 7e11a2a6e0
commit cc59df5651
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
de176c8506d8383f6198a6008e81dd98977a79b4
View File

@ -70,6 +70,30 @@
},
"revId": "de176c8506d8383f6198a6008e81dd98977a79b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cd52199a_03beaf81",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 6
},
"lineNbr": 159,
"author": {
"id": 31503
},
"writtenOn": "2023-10-20T07:35:43Z",
"side": 1,
"message": "Sorry, could have added more context here. So, the generate_intermediate breaks the CA private key in vault versions \u003c 1.10.0, so we cannot use it.\n\nIn the latest patchset, I have reverted to using openssl for generating the csr and private key, hence this code being not relevant any more",
"parentUuid": "e5bd4097_51327f02",
"range": {
"startLine": 157,
"startChar": 0,
"endLine": 159,
"endChar": 73
},
"revId": "de176c8506d8383f6198a6008e81dd98977a79b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}