charm-vault/15d652e924286025214cead3bbd...

72 lines
2.3 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "8a845f3a_be205125",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10058
},
"writtenOn": "2023-12-07T14:42:27Z",
"side": 1,
"message": "As I mentioned concerns before, backporting this to brances \u003c1.7 might cause regression problems which seems to be the case here. So, Im -1 this until we figure out what to do with this.\n\n\"TypeError: \u0027NoneType\u0027 object is not subscriptable\"",
"revId": "15d652e924286025214cead3bbdbc9d66f8bb186",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e2dd260b_981f290f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 14567
},
"writtenOn": "2024-01-09T14:23:05Z",
"side": 1,
"message": "charm-recheck",
"revId": "15d652e924286025214cead3bbdbc9d66f8bb186",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2cd4894a_aee77319",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 14567
},
"writtenOn": "2024-01-09T15:51:14Z",
"side": 1,
"message": "charm-recheck",
"revId": "15d652e924286025214cead3bbdbc9d66f8bb186",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "91ec9be9_bc1ee50b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 14567
},
"writtenOn": "2024-01-19T12:27:27Z",
"side": 1,
"message": "as discussed in the openstack engineering meeting, we reached agreement that the 1.6 and 1.5 backports should be abandoned for several reasons, among them:\n\n- the change is drastic and introduces risk, the fact that the CI is failing in a way that implies vault API is behaving different and that the patch would need further adjustment to address that, introduces even more risk",
"revId": "15d652e924286025214cead3bbdbc9d66f8bb186",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}