openstack
/
charms.ceph
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
CC: Gerrit User 15382 <15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 36974 \u003c36974@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
Gerrit User 15382 2024-04-29 08:25:17 +00:00 committed by Gerrit Code Review
parent 946b7e2346
commit 17155c97ad
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
5473f69024fa655d02311129c719695d8e2588fd Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "54ed75eb_637b45f3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15382
},
"writtenOn": "2024-04-29T08:25:17Z",
"side": 1,
"message": "Thanks Julian, this lgtm in general. Aiui this test the change in Change-Id: I64b8b158d519084b88bd91496124d348fef51123 is that right? \nCan you mention that change id in the commit message for tracking? \nThanks again!",
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04dc7077_1e8c1435",
"filename": "unit_tests/test_broker.py",
"patchSetId": 2
},
"lineNbr": 948,
"author": {
"id": 15382
},
"writtenOn": "2024-04-29T08:25:17Z",
"side": 1,
"message": "Minor nit: suggest to do `json.loads()` only once to avoid repeated expense",
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}