openstack
/
charms.ceph
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 36974 \u003c36974@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36974\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36974\u003e replied on the change"}
This commit is contained in:
Gerrit User 36974 2024-04-29 16:38:16 +00:00 committed by Gerrit Code Review
parent bfccaadc83
commit f68a519a18
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
5473f69024fa655d02311129c719695d8e2588fd
View File

@ -17,6 +17,24 @@
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f546e438_74edfca1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 36974
},
"writtenOn": "2024-04-29T16:38:16Z",
"side": 1,
"message": "Yes, that\u0027s right. Added a mention to the other change.",
"parentUuid": "54ed75eb_637b45f3",
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "Minor nit: suggest to do `json.loads()` only once to avoid repeated expense",
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a0720da5_0dbe8da0",
"filename": "unit_tests/test_broker.py",
"patchSetId": 2
},
"lineNbr": 948,
"author": {
"id": 36974
},
"writtenOn": "2024-04-29T16:38:16Z",
"side": 1,
"message": "Done",
"parentUuid": "04dc7077_1e8c1435",
"revId": "5473f69024fa655d02311129c719695d8e2588fd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}