openstack
/
charms.openstack
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}
This commit is contained in:
Gerrit User 10058 2024-03-19 02:03:47 +00:00 committed by Gerrit Code Review
parent 524b7afb1f
commit 8515b8ac3a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
6695b472563d133506cfb7ca867d05b58d4b4043 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "41f42832_805bc6f9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 10058
},
"writtenOn": "2024-03-19T02:03:47Z",
"side": 1,
"message": "Hey Brian,\n\nSo, for some reason those two patches [1][2] do not pass independently. See their last two runs.\nIf one passes the other fails in the vice versa, so Im squashing them to work around that problem.\n\n\n[1] [ussuri][goal] Updates for python 2.7 drop: https://review.opendev.org/c/openstack/charms.openstack/+/902317/4\n[2] Use unittest.mock instead of mock: https://review.opendev.org/c/openstack/charms.openstack/+/902319",
"revId": "6695b472563d133506cfb7ca867d05b58d4b4043",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}