Update patch set 3
Patch Set 3: (7 comments) Patch-set: 3 CC: Gerrit User 19262 <19262@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 19262
Gerrit Code Review
parent
82ffe4ffdf
commit
14da9e60b2
|
|
@ -16,6 +16,161 @@
|
|||
"message": "I can\u0027t comment on the content yet, but the first line of the message doesn\u0027t really explain what\u0027s going on. The fact that this a possible implementation of a test for some release of a product is irrelevant here, and the commit message should just focus on what is needed here. Please fix .it\n\nAlso, it would be useful to have a testing job (we may have with two cinder backends where the test is executed, because by default is not. I believe cinder-tempest-lvm-multibackend in the cinder repository does that, so you could try a review which depends on this to see if the test is executed.\n\nBut more important, there is already a prior review where the person who proposed it is not working on openstack anymore: https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/835512 \nDoes that cover the same use case? If it does, it would make sense to rebase that review and continue from it.",
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "018b8c60_6523b1f6",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "Thanks Yosi! Please see the comments.",
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7412876a_81f02301",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "The clients mentioned have already been initialized within the setup_clients method of the parent classes.\n\nBy the way, volume_types_client_latest client should be initialized with admin credentials:\ncls.os_admin.volume_types_client_latest rather than cls.os_primary.volume_types_client_latest",
|
||||
"range": {
|
||||
"startLine": 41,
|
||||
"startChar": 0,
|
||||
"endLine": 46,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "89cc2b40_39e21dde",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m not entirely sure, but I think that if validation is enabled we should have a security group.",
|
||||
"range": {
|
||||
"startLine": 59,
|
||||
"startChar": 8,
|
||||
"endLine": 59,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ef9d2ae1_32176d8e",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 91,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "Why if statement if the \"backend_name\" parameter is a required parameter ?",
|
||||
"range": {
|
||||
"startLine": 91,
|
||||
"startChar": 8,
|
||||
"endLine": 91,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d185019d_0d79b4db",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "1 is not enough ?",
|
||||
"range": {
|
||||
"startLine": 99,
|
||||
"startChar": 53,
|
||||
"endLine": 99,
|
||||
"endChar": 55
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b8740317_0e1cee14",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 106,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "Is there a particular reason you\u0027re not utilizing the \u0027create_volume\u0027 helper method?",
|
||||
"range": {
|
||||
"startLine": 101,
|
||||
"startChar": 0,
|
||||
"endLine": 106,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a3f2c83c_e9e7c192",
|
||||
"filename": "cinder_tempest_plugin/scenario/test_volume_backup_restore.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 162,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-01T12:15:06Z",
|
||||
"side": 1,
|
||||
"message": "Is it really necessary?\nThis method returns nothing.",
|
||||
"range": {
|
||||
"startLine": 160,
|
||||
"startChar": 0,
|
||||
"endLine": 162,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "488a6b8e50bb5efef4c98032aae2b226ee1e1170",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue