Update patch set 6
Patch Set 6: (1 comment) Patch-set: 6 Attention: {"person_ident":"Gerrit User 19262 \u003c19262@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_19262\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 35834 \u003c35834@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_19262\u003e replied on the change"}
This commit is contained in:
parent
083625630e
commit
dd7c46e4cd
|
@ -135,6 +135,29 @@
|
|||
"message": "recheck\n\nUnrelated issue in cinder-tempest-plugin-lvm-multiattach",
|
||||
"revId": "c5fd9545d9e5133268bafd530421b1784bad3512",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b210f30d_0ca00085",
|
||||
"filename": "cinder_tempest_plugin/rbac/v3/base.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 19262
|
||||
},
|
||||
"writtenOn": "2024-04-07T09:23:12Z",
|
||||
"side": 1,
|
||||
"message": "I believe it should be placed in the base class since I\u0027ve noticed it\u0027s being used in other places.\nAdditionally, it does not need to be defined as a class method.",
|
||||
"range": {
|
||||
"startLine": 191,
|
||||
"startChar": 4,
|
||||
"endLine": 191,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "c5fd9545d9e5133268bafd530421b1784bad3512",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue