From 3e124edb5dbbd5b48bb8816e6c1b60f5a0fa03db Mon Sep 17 00:00:00 2001 From: Lucian Petrut Date: Fri, 14 Nov 2014 18:22:04 +0200 Subject: [PATCH] Change CHAP secret default length Some of the iSCSI initiators have a limit regarding the maximum CHAP secret length. For example, the MS iSCSI Initiator does not allow CHAP secrets longer than 16 characters, smaller than the actual default 20 characters length. This patch simply changes the default length to 16 characters, value which is already used by default by some of the volume drivers. In fact, the iSCSI specs state that: "Implementations MUST support use of up to 128 bit random CHAP secrets". Change-Id: I0295fabd0c0048c93e1f452077d0f5d19af9784d Closes-Bug: #1392792 --- cinder/volume/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cinder/volume/utils.py b/cinder/volume/utils.py index 24ccf6141dc..a1fd79c094f 100644 --- a/cinder/volume/utils.py +++ b/cinder/volume/utils.py @@ -411,7 +411,7 @@ DEFAULT_PASSWORD_SYMBOLS = ('23456789', # Removed: 0,1 'abcdefghijkmnopqrstuvwxyz') # Removed: l -def generate_password(length=20, symbolgroups=DEFAULT_PASSWORD_SYMBOLS): +def generate_password(length=16, symbolgroups=DEFAULT_PASSWORD_SYMBOLS): """Generate a random password from the supplied symbol groups. At least one symbol from each group will be included. Unpredictable