diff --git a/cinder/service.py b/cinder/service.py index 1199779d04e..a5947221884 100644 --- a/cinder/service.py +++ b/cinder/service.py @@ -86,6 +86,7 @@ class Service(service.Service): self.report_interval = report_interval self.periodic_interval = periodic_interval self.periodic_fuzzy_delay = periodic_fuzzy_delay + self.basic_config_check() self.saved_args, self.saved_kwargs = args, kwargs self.timers = [] @@ -138,6 +139,22 @@ class Service(service.Service): initial_delay=initial_delay) self.timers.append(periodic) + def basic_config_check(self): + """Perform basic config checks before starting service.""" + # Make sure report interval is less than service down time + if self.report_interval: + if CONF.service_down_time <= self.report_interval: + new_down_time = int(self.report_interval * 2.5) + LOG.warn(_("Report interval must be less than service down " + "time. Current config service_down_time: " + "%(service_down_time)s, report_interval for this: " + "service is: %(report_interval)s. Setting global " + "service_down_time to: %(new_down_time)s") % + {'service_down_time': CONF.service_down_time, + 'report_interval': self.report_interval, + 'new_down_time': new_down_time}) + CONF.set_override('service_down_time', new_down_time) + def _create_service_ref(self, context): zone = CONF.storage_availability_zone service_ref = db.service_create(context, @@ -283,28 +300,11 @@ class WSGIService(object): {'name': name}) # Reset workers to default self.workers = None - self.basic_config_check() self.server = wsgi.Server(name, self.app, host=self.host, port=self.port) - def basic_config_check(self): - """Perform basic config checks before starting service.""" - # Make sure report interval is less than service down time - report_interval = CONF.report_interval - if CONF.service_down_time <= report_interval: - new_service_down_time = int(report_interval * 2.5) - LOG.warn(_("Report interval must be less than service down " - "time. Current config: . Setting service_down_time to: " - "%(new_service_down_time)s") % - {'service_down_time': CONF.service_down_time, - 'report_interval': report_interval, - 'new_service_down_time': new_service_down_time}) - CONF.set_override('service_down_time', new_service_down_time) - def _get_manager(self): """Initialize a Manager object appropriate for this service. diff --git a/cinder/tests/test_service.py b/cinder/tests/test_service.py index 2291502c207..0f34a523296 100644 --- a/cinder/tests/test_service.py +++ b/cinder/tests/test_service.py @@ -195,6 +195,13 @@ class ServiceTestCase(test.TestCase): self.assertFalse(serv.model_disconnected) + def test_service_with_long_report_interval(self): + CONF.set_override('service_down_time', 10) + CONF.set_override('report_interval', 10) + service.Service.create(binary="test_service", + manager="cinder.tests.test_service.FakeManager") + self.assertEqual(CONF.service_down_time, 25) + class TestWSGIService(test.TestCase): @@ -208,9 +215,3 @@ class TestWSGIService(test.TestCase): test_service.start() self.assertNotEqual(0, test_service.port) test_service.stop() - - def test_service_with_min_down_time(self): - CONF.set_override('service_down_time', 10) - CONF.set_override('report_interval', 10) - service.WSGIService("test_service") - self.assertEqual(CONF.service_down_time, 25)