openstack
/
cinder
Code Issues Proposed changes

Fix backup compression unit tests 

Cinder backup tests for compression were incorrectly testing the size of
the compression data, instead of testing against the compressed data
they were checking the tuple (algorithm, compressed_data).

This patches fixes those tests.

Change-Id: I02f79a1ccc1af29e1f843e94c0618c8e4962bdae
(cherry picked from commit fd671c77cd)
(cherry picked from commit 9d0658febe)
This commit is contained in:
Gorka Eguileor 2017-09-13 19:53:21 +02:00 committed by Sean McGinnis
parent 09b1b13519
commit b1232cdde8
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/backup/drivers/test_backup_google.py
View File

@ -554,7 +554,7 @@ class GoogleBackupDriverTestCase(test.TestCase):
result = service._prepare_output_data(fake_data)
self.assertEqual('zlib', result[0])
self.assertGreater(len(fake_data), len(result))
self.assertGreater(len(fake_data), len(result[1]))
@gcs_client
def test_prepare_output_data_no_compresssion(self):

2
cinder/tests/unit/backup/drivers/test_backup_nfs.py
View File

@ -682,7 +682,7 @@ class BackupNFSSwiftBasedTestCase(test.TestCase):
result = service._prepare_output_data(fake_data)
self.assertEqual('zlib', result[0])
self.assertGreater(len(fake_data), len(result))
self.assertGreater(len(fake_data), len(result[1]))
def test_prepare_output_data_no_compresssion(self):
self.flags(backup_compression_algorithm='none')

2
cinder/tests/unit/backup/drivers/test_backup_swift.py
View File

@ -805,7 +805,7 @@ class BackupSwiftTestCase(test.TestCase):
result = service._prepare_output_data(fake_data)
self.assertEqual('zlib', result[0])
self.assertGreater(len(fake_data), len(result))
self.assertGreater(len(fake_data), len(result[1]))
def test_prepare_output_data_no_compresssion(self):
self.flags(backup_compression_algorithm='none')