openstack
/
cinder
Code Issues Proposed changes

Dell PowerMax : Disabling the renaming of a volume before deletion 

This change is to speed up the deletion of a volume which doesn't
require to rename the volume prior to delete it.
This removal will allow to save 15s in terms of operation time
and avoid unnecessary pausing time during migration.
This affects only version up to Yoga as this was included into a
bigger patch merged in Zed.
This is just a one line removal and doesn't affect other stuff.

Closes-Bug: #2033398
Change-Id: I80088ba4171516d5848d510bbe986fb92a734e38
This commit is contained in:
Jean-Pierre Roquesalane 2023-09-13 15:56:15 +02:00 committed by happystacker
parent 752c9eacce
commit d02c88346d
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py
View File

@ -759,14 +759,8 @@ class PowerMaxRestTest(test.TestCase):
device_id = self.data.device_id
self.rest.ucode_major_level = utils.UCODE_5978
self.rest.ucode_minor_level = utils.UCODE_5978_HICKORY
with mock.patch.object(
self.rest, 'delete_resource') as mock_delete, (
mock.patch.object(
self.rest, '_modify_volume')) as mock_modify:
with mock.patch.object(self.rest, 'delete_resource') as mock_delete:
self.rest.delete_volume(self.data.array, device_id)
mod_call_count = mock_modify.call_count
self.assertEqual(1, mod_call_count)
mock_delete.assert_called_once_with(
self.data.array, 'sloprovisioning', 'volume', device_id)

2
cinder/volume/drivers/dell_emc/powermax/rest.py
View File

@ -1552,8 +1552,6 @@ class PowerMaxRest(object):
and (self.ucode_minor_level > utils.UCODE_5978_ELMSR)):
# Use Rapid TDEV Deallocation to delete after ELMSR
try:
# Rename volume, removing the OS-<cinderUUID>
self.rename_volume(array, device_id, None)
self.delete_resource(array, SLOPROVISIONING,
"volume", device_id)
except Exception as e:

10
releasenotes/notes/bug-2033398-powermax-reduce-slowness-online-migration-ab0a0ea19672b85c.yaml Normal file
View File

@ -0,0 +1,10 @@
---
fixes:
- |
Dell PowerMax driver `bug #2033398
<https://bugs.launchpad.net/cinder/+bug/2033398>`_: Reduced
the risk of failures when doing online migration.
This change is to speed up the deletion of a volume which doesn't
require to rename the volume prior to delete it.
This removal will allow to save 15s in terms of operation time
and avoid unnecessary pausing time during migration.