openstack
/
cinder
Code Issues Proposed changes
cinder/cinder/tests
History
Matt Riedemann 9c0123eb70 Fix _attachment_reserve to not allow attaching an invalid status volume 
It is currently possible to create a volume attachment for a server
when the volume is in error status because of the override logic
in the _attachment_reserve method. What results is that the volume
attach operation fails in nova-compute which rolls back and deletes
the volume attachment, which puts the volume into 'available' status
because it no longer has any attachments, which in fact it should
have never allowed the attachment create/reserve in the first place.

This updates the override logic such that a volume without any
attachments which is in an invalid status will result in an error
being raised.

Change-Id: Id9cf2f510684cd296ffbcaf53d11889cfe8973b9
Closes-Bug: #1785050
 		2018-08-08 16:44:33 -04:00
..
compliance Use assertEqual/Less/Greater/In/IsNone 2016-07-04 17:58:16 +02:00
functional Fix incorrect use of assertFalse causing CI failed 2017-10-26 11:01:02 +07:00
unit Fix _attachment_reserve to not allow attaching an invalid status volume 2018-08-08 16:44:33 -04:00
README.rst Update the documentation link 2017-08-26 06:52:48 -07:00
__init__.py
…
fake_driver.py FC: refactor fczm utils decorators to functions 2018-04-16 16:23:59 -07:00
fixtures.py Implement privsep boilerplate in cinder. 2018-06-06 09:42:54 +08:00

README.rst

IMPORTANT DEFINITION OF TESTS IN CINDER

Cinder has a number of different test types, PLEASE be sure to refer to the Cinder Testing Docs to familiarize yourself with the various options before creating any new tests.

Please check Cinder-Testing.