openstack
/
cliff
Code Issues Proposed changes

Removing brackets around tested conditional 

While permissible syntactically, using brackets to wrap tested conditional is unnecessary
and potentially confusing. As without inserted whitspace the code may look as a function
call, rather than a statement and expression.

The construct is also considered erroneous by linters.

Closes-Bug: 1983593

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I0a086a8349e2a72cae024857e148fddc3556c319
This commit is contained in:
Jiri Podivin 2022-08-04 16:32:44 +02:00
parent a04a48f4f7
commit 56b700afca
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cliff/tests/test_app.py
View File

@ -321,7 +321,7 @@ class TestOptionParser(base.TestBase):
return parser
def take_action(self, parsed_args):
assert(parsed_args.end == '123')
assert parsed_args.end == '123'
class MyCommandManager(commandmanager.CommandManager):
def load_commands(self, namespace):