openstack
/
compute-hyperv
Code Issues Proposed changes

Remove unnecessary mock 

In one of the unit tests, we unnecessarily mock os.path.join. This
seems to cause the test to hang on Python 3.4, as gettextutils will
hang when attempting to translate one of the messages logged by
the tested method.

For now, we'll just remove this mock as it's blocking the gate.
Still,We may have to understand better why we did not have this
issue before.

Change-Id: I7bec8755d98196eca6e7952cd493a997c71f2ca3
This commit is contained in:
Lucian Petrut 2016-05-25 15:08:51 +03:00
parent b964f2bce3
commit 820f5f8ff4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hyperv/tests/unit/test_pathutils.py
View File

@ -77,8 +77,7 @@ class PathUtilsTestCase(test_base.HyperVBaseTestCase):
self.fake_instance_name)
self.assertIsNone(configdrive_path)
@mock.patch('os.path.join')
def test_get_instances_sub_dir(self, fake_path_join):
def test_get_instances_sub_dir(self):
class WindowsError(Exception):
def __init__(self, winerror=None):