Updated to start metadata-api

This starts the nova-metadata-api service on the compute
nodes when nova-networking is leveraged. This it seems that
in the compute node with nova-networking the service doesn't
start, this patch starts it up and allows for the local machines
to access the metadata-api.

This also updates the test so it confirms that the correct
process starts.

Change-Id: I7e9ce935b2d1e7135809b36684516d146277f8dc

CHANGELOG.md

@@ -19,6 +19,7 @@ This file is used to list changes made in each version of cookbook-openstack-com
 * Add more attributes for nova.conf DEFAULT section
 * Update and remove the outdated options
 * Add cinder_catalog_info
+* Updated the nova-networking to start metadata-api
 
 ## 9.3.1
 * Move auth configuration from api-paste.ini to nova.conf
@@ -154,4 +155,3 @@ This file is used to list changes made in each version of cookbook-openstack-com
 Check the [Markdown Syntax Guide](http://daringfireball.net/projects/markdown/syntax) for help with Markdown.
 
 The [Github Flavored Markdown page](http://github.github.com/github-flavored-markdown/) describes the differences between markdown on github and standard markdown.
-

attributes/default.rb

@@ -418,7 +418,7 @@ when 'fedora', 'rhel', 'suse' # :pragma-foodcritic: ~FC024 - won't fix this
     'neutron_python_packages' => ['python-neutronclient', 'pyparsing'],
     'memcache_python_packages' => ['python-memcached'],
     'compute_api_metadata_packages' => ['openstack-nova-api'],
-    'compute_api_metadata_service' => 'openstack-nova-api',
+    'compute_api_metadata_service' => 'openstack-nova-metadata-api',
     'compute_client_packages' => ['python-novaclient'],
     'compute_compute_packages' => ['openstack-nova-compute'],
     'qemu_compute_packages' => [],

recipes/api-metadata.rb

@@ -47,7 +47,7 @@ service 'nova-api-metadata' do
   supports status: true, restart: true
   subscribes :restart, resources('template[/etc/nova/nova.conf]')
 
-  action :enable
+  action [:enable, :start]
 end
 
 template '/etc/nova/api-paste.ini' do

spec/api-metadata-redhat_spec.rb

@@ -18,7 +18,7 @@ describe 'openstack-compute::api-metadata' do
     end
 
     it 'starts metadata api on boot' do
-      expect(chef_run).to enable_service 'openstack-nova-api'
+      expect(chef_run).to enable_service 'nova-api-metadata'
     end
   end
 end

spec/api-metadata_spec.rb

@@ -22,6 +22,10 @@ describe 'openstack-compute::api-metadata' do
       expect(chef_run).to enable_service 'nova-api-metadata'
     end
 
+    it 'starts metadata api now' do
+      expect(chef_run).to start_service 'nova-api-metadata'
+    end
+
     expect_creates_api_paste 'service[nova-api-metadata]'
   end
 end