Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 21961 2019-11-18 23:15:25 +00:00 committed by Gerrit Code Review
parent 5c6638bd3a
commit 6ae9f0f7e7
2 changed files with 54 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"revId": "0c072b88b959519504a59cfa672902d35fa4af7f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_c6b0698e",
"filename": "attributes/default.rb",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 21961
},
"writtenOn": "2019-11-18T23:15:25Z",
"side": 1,
"message": "\u003e Wouldn\u0027t you drop \"telemetry\" from this loop completely, if that is\n \u003e defining the API endpoint?\n\nThis is true and the reason I kept it in here was because it was being referenced in identity_registration do to the loop it was using. We still need a \"ceilometer\" service, tenant and user. However we _do not_ need an endpoint.\n\nPerhaps it makes sense to remove it here and refactor identity_registration?",
"parentUuid": "3fa7e38b_ba90e74f",
"revId": "0c072b88b959519504a59cfa672902d35fa4af7f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_06e521a4",
"filename": "attributes/ceilometer_conf.rb",
"patchSetId": 2
},
"lineNbr": 5,
"author": {
"id": 21961
},
"writtenOn": "2019-11-18T23:15:25Z",
"side": 0,
"message": "\u003e How is this related to dropping telemetry-api?\n\nThis is more related to this being deprecated in this change: https://review.opendev.org/435899",
"parentUuid": "3fa7e38b_da93634d",
"revId": "fd3d9ceb621e5f82a8278cce23e623393a98c160",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_7a6fcf5f",
@ -33,6 +51,24 @@
"revId": "fd3d9ceb621e5f82a8278cce23e623393a98c160",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_a651ad32",
"filename": "spec/gnocchi_install_spec.rb",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 21961
},
"writtenOn": "2019-11-18T23:15:25Z",
"side": 0,
"message": "Done",
"parentUuid": "3fa7e38b_7a6fcf5f",
"revId": "fd3d9ceb621e5f82a8278cce23e623393a98c160",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}