diff --git a/attributes/ceilometer_conf.rb b/attributes/ceilometer_conf.rb index 9459c9a..f48cdb1 100644 --- a/attributes/ceilometer_conf.rb +++ b/attributes/ceilometer_conf.rb @@ -2,7 +2,6 @@ default['openstack']['telemetry']['conf_secrets'] = {} default['openstack']['telemetry']['conf'].tap do |conf| # [DEFAULT] section - conf['DEFAULT']['rpc_backend'] = node['openstack']['mq']['service_type'] conf['DEFAULT']['meter_dispatchers'] = 'gnocchi' # [keystone_authtoken] section conf['keystone_authtoken']['username'] = 'ceilometer' diff --git a/attributes/gnocchi_conf.rb b/attributes/gnocchi_conf.rb index 032c089..8d813b5 100644 --- a/attributes/gnocchi_conf.rb +++ b/attributes/gnocchi_conf.rb @@ -1,8 +1,6 @@ default['openstack']['telemetry-metric']['conf_secrets'] = {} default['openstack']['telemetry-metric']['conf'].tap do |conf| - # [DEFAULT] section - conf['DEFAULT']['rpc_backend'] = node['openstack']['mq']['service_type'] # [keystone_authtoken] section conf['keystone_authtoken']['username'] = 'gnocchi' conf['keystone_authtoken']['project_name'] = 'service' diff --git a/recipes/common.rb b/recipes/common.rb index a7e23ae..78f252b 100644 --- a/recipes/common.rb +++ b/recipes/common.rb @@ -44,13 +44,8 @@ platform['common_packages'].each do |pkg| end end -if node['openstack']['telemetry']['conf']['DEFAULT']['rpc_backend'] == 'rabbit' - user = node['openstack']['mq']['telemetry']['rabbit']['userid'] - node.default['openstack']['telemetry']['conf_secrets'] - .[]('oslo_messaging_rabbit')['rabbit_userid'] = user - node.default['openstack']['telemetry']['conf_secrets'] - .[]('oslo_messaging_rabbit')['rabbit_password'] = - get_password 'user', user +if node['openstack']['mq']['service_type'] == 'rabbit' + node.default['openstack']['telemetry']['conf_secrets']['DEFAULT']['transport_url'] = rabbit_transport_url 'telemetry' end db_user = node['openstack']['db']['telemetry']['username'] diff --git a/spec/common_spec.rb b/spec/common_spec.rb index aec8b1f..d9fdb8f 100644 --- a/spec/common_spec.rb +++ b/spec/common_spec.rb @@ -116,11 +116,10 @@ describe 'openstack-telemetry::common' do it do [ - /^rabbit_userid = guest$/, - /^rabbit_password = mq-pass$/ + %r{^transport_url = rabbit://guest:mypass@127.0.0.1:5672$} ].each do |line| expect(chef_run).to render_config_file(file.name) - .with_section_content('oslo_messaging_rabbit', line) + .with_section_content('DEFAULT', line) end end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 20d4520..f16b772 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -41,6 +41,9 @@ shared_context 'telemetry-stubs' do allow_any_instance_of(Chef::Recipe).to receive(:get_password) .with('user', 'admin') .and_return('admin-pass') + allow_any_instance_of(Chef::Recipe).to receive(:rabbit_transport_url) + .with('telemetry') + .and_return('rabbit://guest:mypass@127.0.0.1:5672') allow(Chef::Application).to receive(:fatal!) stub_command('/usr/sbin/apache2 -t') stub_command('/usr/sbin/httpd -t')