openstack
/
cyborg
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(4 comments)

Patch-set: 5
Reviewer: Gerrit User 31412 <31412@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 1aea3286efc14d684175774aa034d91ca38c6f4b
Attention: {"person_ident":"Gerrit User 34665 \u003c34665@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31412\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31412 \u003c31412@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31412\u003e replied on the change"}
This commit is contained in:
Gerrit User 31412 2023-08-18 02:53:43 +00:00 committed by Gerrit Code Review
parent 407f61dd8a
commit 884e4cb03b
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
0b76cd8fb1a4ffbaa84caa446daa409af02ed634 Normal file
View File

@ -0,0 +1,96 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "a1442506_7ef08d2a",
"filename": "cyborg/api/controllers/v2/devices.py",
"patchSetId": 5
},
"lineNbr": 144,
"author": {
"id": 31412
},
"writtenOn": "2023-08-18T02:53:43Z",
"side": 1,
"message": "need add microversion check.\nref:https://review.opendev.org/c/openstack/cyborg/+/817516",
"range": {
"startLine": 144,
"startChar": 0,
"endLine": 144,
"endChar": 39
},
"revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "464acbbc_b0a10384",
"filename": "cyborg/api/controllers/v2/utils.py",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 31412
},
"writtenOn": "2023-08-18T02:53:43Z",
"side": 1,
"message": "please remove to common/placement_client.py",
"range": {
"startLine": 30,
"startChar": 0,
"endLine": 47,
"endChar": 77
},
"revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d4aaebd9_b221f78b",
"filename": "cyborg/common/placement_client.py",
"patchSetId": 5
},
"lineNbr": 158,
"author": {
"id": 31412
},
"writtenOn": "2023-08-18T02:53:43Z",
"side": 1,
"message": "the latest version is invalid?",
"range": {
"startLine": 158,
"startChar": 37,
"endLine": 158,
"endChar": 53
},
"revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cbc0ed45_e52e4604",
"filename": "cyborg/common/policy.py",
"patchSetId": 5
},
"lineNbr": 52,
"author": {
"id": 31412
},
"writtenOn": "2023-08-18T02:53:43Z",
"side": 1,
"message": "rule:allow",
"range": {
"startLine": 52,
"startChar": 0,
"endLine": 52,
"endChar": 40
},
"revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}