openstack
/
deb-python-gnocchiclient
Code Issues Proposed changes

Remove redundant parentheses 

Change-Id: I80fcdb427b9761b42dcd95d577d8e2da8aa9ee8e
This commit is contained in:
Eyal 2016-04-05 09:36:03 +03:00
parent 25cd3c6cda
commit 8d0657306a
5 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gnocchiclient/tests/functional/test_metric.py
View File

@ -136,7 +136,7 @@ class MetricClientTest(base.ClientTestBase):
with tmpfile as f:
f.write(measures.encode('utf8'))
self.gnocchi('measures', params=("batch-metrics %s" % tmpfile.name))
self.gnocchi('measures', params=("batch-metrics -"),
self.gnocchi('measures', params="batch-metrics -",
input=measures.encode('utf8'))
# LIST
@ -252,7 +252,7 @@ class MetricClientTest(base.ClientTestBase):
self.gnocchi('measures', params=("batch-resources-metrics %s" %
tmpfile.name))
self.gnocchi('measures', params=("batch-resources-metrics -"),
self.gnocchi('measures', params="batch-resources-metrics -",
input=measures.encode('utf8'))
# LIST

2
gnocchiclient/tests/functional/test_resource.py
View File

@ -175,7 +175,7 @@ class ResourceClientTest(base.ClientTestBase):
self.assertNotIn(self.RESOURCE_ID, resource_ids)
self.assertNotIn(self.RESOURCE_ID2, resource_ids)
# LIST THE RESOUCES TYPES
# LIST THE RESOURCES TYPES
result = self.gnocchi(
'resource', params="list-types")
r = self.parser.listing(result)

6
gnocchiclient/v1/archive_policy_cli.py
View File

@ -66,14 +66,14 @@ class CliArchivePolicyCreate(show.ShowOne):
def get_parser(self, prog_name):
parser = super(CliArchivePolicyCreate, self).get_parser(prog_name)
parser.add_argument("name", help=("name of the archive policy"))
parser.add_argument("name", help="name of the archive policy")
parser.add_argument("-b", "--back-window", dest="back_window",
type=int,
help=("back window of the archive policy"))
help="back window of the archive policy")
parser.add_argument("-m", "--aggregation-method",
action="append",
dest="aggregation_methods",
help=("aggregation method of the archive policy"))
help="aggregation method of the archive policy")
parser.add_argument("-d", "--definition", action='append',
required=True, type=archive_policy_definition,
metavar="<DEFINITION>",

6
gnocchiclient/v1/archive_policy_rule_cli.py
View File

@ -49,14 +49,14 @@ class CliArchivePolicyRuleCreate(show.ShowOne):
def get_parser(self, prog_name):
parser = super(CliArchivePolicyRuleCreate, self).get_parser(prog_name)
parser.add_argument("name",
help=("Rule name"))
help="Rule name")
parser.add_argument("-a", "--archive-policy-name",
dest="archive_policy_name",
required=True,
help=("Archive policy name"))
help="Archive policy name")
parser.add_argument("-m", "--metric-pattern",
dest="metric_pattern", required=True,
help=("Wildcard of metric name to match"))
help="Wildcard of metric name to match")
return parser
def take_action(self, parsed_args):

4
gnocchiclient/v1/metric_cli.py
View File

@ -66,7 +66,7 @@ class CliMetricCreateBase(show.ShowOne, CliMetricWithResourceID):
parser = super(CliMetricCreateBase, self).get_parser(prog_name)
parser.add_argument("--archive-policy-name", "-a",
dest="archive_policy_name",
help=("name of the archive policy"))
help="name of the archive policy")
return parser
def take_action(self, parsed_args):
@ -230,7 +230,7 @@ class CliMeasuresAggregation(lister.Lister):
if parsed_args.query:
query = utils.search_query_builder(parsed_args.query)
if len(parsed_args.metric) != 1:
raise ValueError("One metric is required if query is provied")
raise ValueError("One metric is required if query is provided")
metrics = parsed_args.metric[0]
measures = self.app.client.metric.aggregation(
metrics=metrics,