openstack
/
deb-python-gnocchiclient
Code Issues Proposed changes

metric: rename metric get to show 

Everything else uses show.

Change-Id: I61bd87f3b9e4e0d5a1f75fd05296c9538531d8e9
This commit is contained in:
Julien Danjou 2015-10-09 17:31:14 +02:00
parent c4b3be9d8e
commit a2db7c74a2
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gnocchiclient/shell.py
View File

@ -57,7 +57,7 @@ class GnocchiCommandManager(commandmanager.CommandManager):
"metric show": metric_cli.CliMetricShow,
"metric create": metric_cli.CliMetricCreate,
"metric delete": metric_cli.CliMetricDelete,
"measures get": metric_cli.CliMeasuresGet,
"measures show": metric_cli.CliMeasuresShow,
"measures add": metric_cli.CliMeasuresAdd,
"measures aggregation": metric_cli.CliMeasuresAggregation,
"capabilities list": capabilities_cli.CliCapabilitiesList,

4
gnocchiclient/tests/functional/test_metric.py
View File

@ -94,7 +94,7 @@ class MetricClientTest(base.ClientTestBase):
# MEASURES GET
result = self.retry_gnocchi(
5, 'measures', params=("get %s "
5, 'measures', params=("show %s "
"--aggregation mean "
"--start 2015-03-06T14:32:00 "
"--end 2015-03-06T14:36:00"
@ -185,7 +185,7 @@ class MetricClientTest(base.ClientTestBase):
# MEASURES GET
result = self.retry_gnocchi(
5, 'measures', params=("get metric-name -r metric-res "
5, 'measures', params=("show metric-name -r metric-res "
"--aggregation mean "
"--start 2015-03-06T14:32:00 "
"--end 2015-03-06T14:36:00"))

4
gnocchiclient/v1/metric_cli.py
View File

@ -99,11 +99,11 @@ class CliMetricDelete(CliMetricWithResourceID):
resource_id=parsed_args.resource_id)
class CliMeasuresGet(CliMetricWithResourceID, lister.Lister):
class CliMeasuresShow(CliMetricWithResourceID, lister.Lister):
COLS = ('timestamp', 'granularity', 'value')
def get_parser(self, prog_name):
parser = super(CliMeasuresGet, self).get_parser(prog_name)
parser = super(CliMeasuresShow, self).get_parser(prog_name)
parser.add_argument("metric",
help="ID or name of the metric")
parser.add_argument("--aggregation",