From 17d4d6f66f4774c2b3886fe21fef8d40ce77cc0a Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Tue, 15 Jul 2014 12:26:06 -0400 Subject: [PATCH] socket: Add some comments; a bit more obvious variable naming --- greenio/socket.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/greenio/socket.py b/greenio/socket.py index 2236927..a8400c6 100644 --- a/greenio/socket.py +++ b/greenio/socket.py @@ -20,19 +20,21 @@ class socket: def __init__(self, *args, _from_sock=None, **kwargs): if _from_sock: - sock = None + own_sock = None self._sock = _from_sock else: - sock = std_socket(*args, **kwargs) - self._sock = sock + own_sock = std_socket(*args, **kwargs) + self._sock = own_sock try: self._sock.setblocking(False) self._loop = asyncio.get_event_loop() assert isinstance(self._loop, GreenUnixSelectorLoop), \ 'GreenUnixSelectorLoop event loop is required' except: - if sock is not None: - sock.close() + if own_sock is not None: + # An unexpected error has occurred. Close the + # socket object if it was created in __init__. + own_sock.close() raise @classmethod