Remove 'states' field from OSC CLI output

Change-Id: Ice89028865660419b03b5fe40d118a9ae6c75dac
Closes-Bug: #1662934

ironicclient/osc/v1/baremetal_node.py

@@ -424,6 +424,7 @@ class CreateBaremetalNode(command.ShowOne):
         node.pop('links', None)
         node.pop('ports', None)
         node.pop('portgroups', None)
+        node.pop('states', None)
 
         node.setdefault('chassis_uuid', '')
 
@@ -1112,6 +1113,7 @@ class ShowBaremetalNode(command.ShowOne):
         node.pop("links", None)
         node.pop("ports", None)
         node.pop('portgroups', None)
+        node.pop('states', None)
 
         if not fields or 'chassis_uuid' in fields:
             node.setdefault('chassis_uuid', '')

ironicclient/tests/unit/osc/v1/test_baremetal_node.py

@@ -330,6 +330,7 @@ class TestBaremetalCreate(TestBaremetal):
         collist = copy.copy(self.collist)
         self.assertEqual(collist, columns)
         self.assertNotIn('ports', columns)
+        self.assertNotIn('states', columns)
 
         datalist = copy.copy(self.datalist)
         self.assertEqual(datalist, tuple(data))
@@ -2036,6 +2037,7 @@ class TestBaremetalShow(TestBaremetal):
                    )
         self.assertEqual(collist, columns)
         self.assertNotIn('ports', columns)
+        self.assertNotIn('states', columns)
         datalist = (
             baremetal_fakes.baremetal_chassis_uuid_empty,
             baremetal_fakes.baremetal_instance_uuid,

releasenotes/notes/remove-states-field-0242960d121a09a7.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - Hides 'states' field in 'node create' and 'node show'
+    OSC subcommands output because this field is not meant
+    to be present in the output.