openstack
/
deb-python-kafka
Code Issues Proposed changes

Alter test skips: python-lz4 works on python26, but not pypy

This commit is contained in:
Dana Powers 2017-03-14 11:38:49 -07:00
parent fea10d9c16
commit a00f9ead16
3 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/test_buffer.py
View File

@ -2,6 +2,7 @@
from __future__ import absolute_import
import io
import platform
import pytest
@ -34,7 +35,8 @@ def test_buffer_close():
@pytest.mark.parametrize('compression', [
'gzip',
'snappy',
pytest.mark.skipif("sys.version_info < (2,7)")('lz4'), # lz4tools does not work on py26
pytest.mark.skipif(platform.python_implementation() == 'PyPy',
reason='python-lz4 crashes on older versions of pypy')('lz4'),
])
def test_compressed_buffer_close(compression):
records = MessageSetBuffer(io.BytesIO(), 100000, compression_type=compression)

13
test/test_codec.py
View File

@ -1,3 +1,6 @@
from __future__ import absolute_import
import platform
import struct
import pytest
@ -80,7 +83,8 @@ def test_snappy_encode_xerial():
assert compressed == to_ensure
@pytest.mark.skipif(not has_lz4(), reason="LZ4 not available")
@pytest.mark.skipif(not has_lz4() or platform.python_implementation() == 'PyPy',
reason="python-lz4 crashes on old versions of pypy")
def test_lz4():
for i in xrange(1000):
b1 = random_string(100).encode('utf-8')
@ -89,7 +93,8 @@ def test_lz4():
assert b1 == b2
@pytest.mark.skipif(not has_lz4(), reason="LZ4 not available")
@pytest.mark.skipif(not has_lz4() or platform.python_implementation() == 'PyPy',
reason="python-lz4 crashes on old versions of pypy")
def test_lz4_old():
for i in xrange(1000):
b1 = random_string(100).encode('utf-8')
@ -98,8 +103,8 @@ def test_lz4_old():
assert b1 == b2
@pytest.mark.xfail(reason="lz4tools library doesnt support incremental decompression")
@pytest.mark.skipif(not has_lz4(), reason="LZ4 not available")
@pytest.mark.skipif(not has_lz4() or platform.python_implementation() == 'PyPy',
reason="python-lz4 crashes on old versions of pypy")
def test_lz4_incremental():
for i in xrange(1000):
# lz4 max single block size is 4MB

4
test/test_producer.py
View File

@ -31,8 +31,8 @@ def test_end_to_end(kafka_broker, compression):
# LZ4 requires 0.8.2
if version() < (0, 8, 2):
return
# LZ4 python libs don't work on python2.6
elif sys.version_info < (2, 7):
# python-lz4 crashes on older versions of pypy
elif platform.python_implementation() == 'PyPy':
return
connect_str = 'localhost:' + str(kafka_broker.port)