openstack
/
deb-python-neutronclient
Code Issues Proposed changes

Now empty tags are not added to Networks 

Added a check if the tag values is empty or not before adding that tag
to the network.

Change-Id: I92659da97fe829a7715d0bef5570a4d9c5db95da
Closes-Bug: #1603292
This commit is contained in:
M V P Nitesh 2017-04-24 17:25:45 +05:30 committed by Armando Migliaccio
parent 2e60acdff2
commit 235c4e60aa
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
neutronclient/neutron/v2_0/tag.py
View File

@ -50,6 +50,9 @@ class AddTag(neutronv20.NeutronCommand):
def take_action(self, parsed_args):
client = self.get_client()
if not parsed_args.tag:
raise exceptions.CommandError(
_('Cannot add an empty value as tag'))
resource_type, resource_id = _convert_resource_args(client,
parsed_args)
client.add_tag(resource_type, resource_id, parsed_args.tag)

8
neutronclient/tests/unit/test_cli20_tag.py
View File

@ -81,6 +81,14 @@ class CLITestV20Tag(test_cli20.CLITestV20Base):
'--tag', 'red']
self._test_tag_operation(cmd, path, 'PUT', args, "tag-add")
def test_add_tag_empty_tag(self):
cmd = tag.AddTag(test_cli20.MyApp(sys.stdout), None)
path = self._make_tag_path('network', 'myid', '')
args = ['--resource-type', 'network', '--resource', 'myid',
'--tag', '']
self.assertRaises(exceptions.CommandError, self._test_tag_operation,
cmd, path, 'PUT', args, "tag-add")
def test_replace_tag(self):
cmd = tag.ReplaceTag(test_cli20.MyApp(sys.stdout), None)
path = self._make_tags_path('network', 'myid')