openstack
/
deb-python-neutronclient
Code Issues Proposed changes

CLI implementation should raise CommandError 

NeutronClientException is an exception raised from API bindings
and it should not be used in CLI layer.

TrivialFix

Change-Id: I3df4c7352c96f10388df65bd16016b3ceb221248
This commit is contained in:
Akihiro Motoki 2017-06-15 08:54:49 +09:00
parent 41961a25fd
commit d6d42af64a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutronclient/neutron/v2_0/quota.py
View File

@ -207,7 +207,7 @@ class UpdateQuota(neutronV20.NeutronCommand, show.ShowOne):
except Exception:
message = (_('Quota limit for %(name)s must be an integer') %
{'name': name})
raise exceptions.NeutronClientException(message=message)
raise exceptions.CommandError(message=message)
return return_value
def args2body(self, parsed_args):

4
neutronclient/tests/unit/test_quota.py
View File

@ -37,7 +37,7 @@ class CLITestV20Quota(test_cli20.CLITestV20Base):
test_cli20.MyApp(sys.stdout), None)
args = ['--tenant-id', self.test_id, '--network', 'test']
self.assertRaises(
exceptions.NeutronClientException, self._test_update_resource,
exceptions.CommandError, self._test_update_resource,
resource, cmd, self.test_id, args=args,
extrafields={'network': 'new'})
@ -58,7 +58,7 @@ class CLITestV20Quota(test_cli20.CLITestV20Base):
test_cli20.MyApp(sys.stdout), None)
args = [self.test_id, '--network', 'test']
self.assertRaises(
exceptions.NeutronClientException, self._test_update_resource,
exceptions.CommandError, self._test_update_resource,
resource, cmd, self.test_id, args=args,
extrafields={'network': 'new'})