openstack
/
deb-spice-html5
Code Issues Proposed changes

playback: Don't try to access undefined source buffer 

The playback code first tries to access this.source_buffer and then
would check whether it's defined.

This was causing unwanted exception to be thrown in the cockpit
spice-html5 plugin.
This commit is contained in:
Oliver Gutierrez 2016-07-28 10:50:05 +01:00 committed by Christophe Fergeau
parent a8c406377e
commit 667f16c2a4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
playback.js
View File

@ -100,6 +100,9 @@ SpicePlaybackConn.prototype.process_channel_message = function(msg)
data.time = this.last_data_time + 1;
}
if (! this.source_buffer)
return true;
/* Gap detection: If there has been a delay since our last packet, then audio must
have paused. Handling that gets tricky. In Chrome, you can seek forward,
but you cannot in Firefox. And seeking forward in Chrome is nice, as it keeps
@ -120,9 +123,6 @@ SpicePlaybackConn.prototype.process_channel_message = function(msg)
PLAYBACK_DEBUG > 1 && console.log("PlaybackData; time " + data.time + "; length " + data.data.byteLength);
if (! this.source_buffer)
return true;
if (this.start_time == 0)
this.start_playback(data);