From bef5ed102a1b689e88d023f9853d4615921b5787 Mon Sep 17 00:00:00 2001 From: Chris Yeoh Date: Wed, 29 Oct 2014 12:35:52 +1030 Subject: [PATCH] Add requirement for APIImpact flag Adds a requirement for an APIImpact flag in the commit message for a proposed spec if it proposes changes to the Designate REST API. This will make it much easier for people such as the API WG who want to review API changes across OpenStack to find and review proposed API changes. Change-Id: I4ce6a27127cd0af21d4a160ce446076c38258874 --- specs/template.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/specs/template.rst b/specs/template.rst index 96ff966..2de630d 100644 --- a/specs/template.rst +++ b/specs/template.rst @@ -22,6 +22,15 @@ https://blueprints.launchpad.net/designate/+spec/example Introduction paragraph -- why are we doing anything? +If your specification proposes any changes to the Designate REST API such +as changing parameters which can be returned or accepted, or even +the semantics of what happens when a client calls into the API, then +you should add the APIImpact flag to the commit message. Specifications with +the APIImpact flag can be found with the following query:: + +https://review.openstack.org/#/q/status:open+project:openstack/designate-specs+message:apiimpact,n,z + + Problem description ===================