openstack
/
designate
Code Issues Proposed changes

Partitoner references invalid exception class 

The partitioner references an non-existent exception. Additionally,
the exception it intended to catch was *extremely* generic, and it's
attempted recovery was flawed. It should be save to fix that all up
in this review, as this code has never actually be executed.

Change-Id: Ib3e885baa03ea7de0a23f8b4aaed5feb2ea4e234
Closes-Bug: 1560950
This commit is contained in:
Kiall Mac Innes 2016-03-23 12:14:53 +00:00
parent 8030341da5
commit 6a21a790b7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
designate/coordination.py
View File

@ -140,8 +140,11 @@ class Partitioner(object):
get_members_req = self._coordinator.get_members(group_id)
try:
return get_members_req.get()
except tooz.ToozError:
self.join_group(group_id)
except tooz.coordination.GroupNotCreated:
LOG.error(_LE('Attempting to partition over a non-existent group: '
'%s'), self._group_id)
raise
def _on_group_change(self, event):
LOG.debug("Received member change %s" % event)