openstack
/
diskimage-builder
Code Issues Proposed changes

Merge "Ensure scripts are set -u"

This commit is contained in:
Jenkins 2014-05-22 03:03:28 +00:00 committed by Gerrit Code Review
parent 9941326be6 e0650572f2
commit 273d364fc4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bin/dib-lint
View File

@ -72,7 +72,7 @@ for i in $(find elements -type f); do
fi
fi
# Check that all scripts are set -e
# Check that all scripts are set -eu
# NOTE(bnemec): This doesn't verify that the set call occurs high
# enough in the file to be useful, but hopefully nobody will be
# sticking set calls at the end of their file to trick us. And if
@ -88,6 +88,12 @@ for i in $(find elements -type f); do
rc=1
fi
fi
if ! excluded setu; then
if [ -z "$(grep "^set -[^ ]*u" $i)" ]; then
echo "ERROR: $i is not set -u"
rc=1
fi
fi
fi
done