From 55537519e51de064e78795d260e1fed1af1a352a Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Fri, 8 Dec 2017 14:22:47 +1100
Subject: [PATCH] Check source-repository-* files for trailing newline

Because we read this in via a bash loop, without a trailing newline we
can hit one of the oldest bash gotcha tricks and end up skipping the
final line (or only line, if there's only one) when the description
files don't have trailing newlines.  Add a check.

Change-Id: I23e293b957cd4f008611656cf9166391b1b537a2
---
 bin/dib-lint | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/bin/dib-lint b/bin/dib-lint
index b76e78a4f..e1e3c82d1 100755
--- a/bin/dib-lint
+++ b/bin/dib-lint
@@ -86,6 +86,15 @@ for i in $(find $ELEMENTS_DIR -type f \
 
     exclusions=("$(parse_exclusions $i)")
 
+    # source-repository does a read < $file and can miss the last line
+    # (or only line, if there's only one) when not newline terminated.
+    if [[ $(basename "${i}") =~ "source-repository-" ]]; then
+        nl=$(tail -c 1 ${i})
+        if [[ "${nl}" != "" ]]; then
+            error "$i does not end with a newline"
+        fi
+    fi
+
     # Check that files starting with a shebang are +x
     firstline=$(head -n 1 "$i")
     if [ "${firstline:0:2}" = "#!" ]; then