openstack
/
ec2-api
Code Issues Proposed changes

Update patch set 2 

Abandoned

project has been retired now https://review.opendev.org/c/openstack/governance/+/919394

Patch-set: 2
Status: abandoned
Tag: autogenerated:gerrit:abandon
This commit is contained in:
Gerrit User 8556 2024-05-15 03:22:21 +00:00 committed by Gerrit Code Review
parent d6017ebb05
commit daf1ad8a35
1 changed files with 81 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
69f7fe086e930665c95dbb760b8ab21533676a2b
View File

@ -1,6 +1,7 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "5ff73747_4a85f4ac",
"filename": "ec2api/api/instance.py",
@ -20,10 +21,10 @@
"endChar": 66
},
"revId": "69f7fe086e930665c95dbb760b8ab21533676a2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5ff73747_cd0a3e89",
"filename": "ec2api/api/instance.py",
@ -37,8 +38,84 @@
"side": 1,
"message": "Are you sure we need this for metadata server? _get_os_flavor is called from inside run_instances and modify_instance_attribute only...",
"revId": "69f7fe086e930665c95dbb760b8ab21533676a2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Code reviewed by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "69f7fe086e930665c95dbb760b8ab21533676a2b",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Verified in gate by CI"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "69f7fe086e930665c95dbb760b8ab21533676a2b",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Workflow",
"description": {
"value": "Approved for gate by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "69f7fe086e930665c95dbb760b8ab21533676a2b",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}