openstack
/
fuel-devops
Code Issues Proposed changes

Merge "Extend _ManageSSH docstring with a note for current directory"

This commit is contained in:
Jenkins 2016-08-01 14:03:31 +00:00 committed by Gerrit Code Review
parent 08d0520f7a 26f9ab7dbc
commit 19c08d8188
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
devops/helpers/ssh_client.py
View File

@ -195,9 +195,17 @@ class _MemorizedSSH(type):
Main flow is:
SSHClient() -> check for cached connection and
if exists the same: check for alive, reconnect if required and return
if exists with different credentials: delete and continue processing
create new connection and cache on success
- If exists the same: check for alive, reconnect if required and return
- If exists with different credentials: delete and continue processing
create new connection and cache on success
* Note: each invocation of SSHClient instance will return current dir to
the root of the current user home dir ("cd ~").
It is necessary to avoid unpredictable behavior when the same
connection is used from different places.
If you need to enter some directory and execute command there, please
use the following approach:
cmd1 = "cd <some dir> && <command1>"
cmd2 = "cd <some dir> && <command2>"
Close cached connections is allowed per-client and all stored:
connection will be closed, but still stored in cache for faster reconnect