Set permissions for /dev/kvm

if we just installed the package, udev rules aren't picked up yet,
so udev may have created the device (/dev/kvm) with default
permissions which affects reduced footprint feature.

Change-Id: I066852220ee75defb6cf1bc364bea32c098fa307
Closes-Bug: #1524978

deployment/puppet/osnailyfacter/modular/generate_vms/generate_vms.pp

@@ -47,3 +47,15 @@ exec { 'generate_vms':
   path        => ['/usr/sbin', '/usr/bin' , '/sbin', '/bin'],
   require     => [File["${template_dir}"], File["${libvirt_dir}/autostart"]],
 }
+
+if $::operatingsystem == 'Ubuntu' {
+  # TODO(mpolenchuk): Remove when LP#1057024 has been resolved.
+  # https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/1057024
+  file { '/dev/kvm':
+    ensure => present,
+    group  => 'kvm',
+    mode   => '0660',
+  }
+
+  Package<||> ~> File['/dev/kvm'] -> Exec['generate_vms']
+}

tests/noop/spec/hosts/generate_vms/generate_vms_spec.rb

@@ -53,6 +53,16 @@ describe manifest do
       end
     end
 
+    it 'should set permissions for /dev/kvm under Ubuntu' do
+      if facts[:operatingsystem] == 'Ubuntu'
+        should contain_file('/dev/kvm').with(
+          :ensure => 'present',
+          :group  => 'kvm',
+          :mode   => '0660',
+        ).that_comes_before('Exec[generate_vms]')
+      end
+    end
+
   end
   test_ubuntu_and_centos manifest
 end