Fix puppet syntax errors (lint)

- Bump puppet-lint version to 1.1
- Remove excessive spaces causing lint error messages

Change-Id: I7ee922ea09d3dff520c8c80791cb54bdff9bc5fc
Closes-bug: #1552183

deployment/puppet/ceph/Gemfile

@@ -5,7 +5,7 @@ group :development, :test do
   gem 'rspec', '~>3.3',          :require => false
   gem 'rspec-puppet', '~>2.1.0', :require => false
   gem 'puppetlabs_spec_helper',  :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'puppet-lint', '~> 1.1'
 end
 
 if puppetversion = ENV['PUPPET_GEM_VERSION']

deployment/puppet/cgroups/Gemfile

@@ -6,7 +6,7 @@ group :development, :test do
   gem 'rspec', '~>3.3',          :require => false
   gem 'rspec-puppet', '~>2.2.0', :require => false
   gem 'puppetlabs_spec_helper',  :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'puppet-lint', '~> 1.1'
   gem 'json',                    :require => false
 end
 

deployment/puppet/cgroups/manifests/params.pp

@@ -3,7 +3,7 @@ class cgroups::params {
   case $::osfamily {
     'Debian': {
       $packages = ['cgroup-bin', 'libcgroup1', 'cgroup-upstart']
-     }
+    }
     default: {
       fail("Unsupported platform")
     }

deployment/puppet/cgroups/manifests/service.pp

@@ -15,7 +15,7 @@ class cgroups::service (
   service { 'cgrulesengd':
     ensure => running,
   }
-  
+
   $cgclass_res = map_cgclassify_opts($cgroups_settings)
   unless empty($cgclass_res) {
     create_resources('cgclassify', $cgclass_res, { 'ensure' => present })

deployment/puppet/haproxy/Gemfile

@@ -5,7 +5,7 @@ group :development, :unit_tests do
   gem 'rspec-core', '~> 3.3',     :require => 'false'
   gem 'rspec-puppet', '~> 2.2.0', :require => 'false'
   gem 'puppetlabs_spec_helper',   :require => 'false'
-  gem 'puppet-lint',              '~> 0.3.2'
+  gem 'puppet-lint',              '~> 1.1'
   gem 'simplecov',                :require => 'false'
   gem 'puppet_facts',             :require => 'false'
   gem 'json',                     :require => 'false'

deployment/puppet/l23network/Gemfile

@@ -6,7 +6,7 @@ group :development, :test do
   gem 'rspec', '~>3.3',          :require => false
   gem 'rspec-puppet', '~>2.2.0', :require => false
   gem 'puppetlabs_spec_helper',  :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'puppet-lint', '~> 1.1'
 end
 
 if puppetversion = ENV['PUPPET_GEM_VERSION']

deployment/puppet/l23network/manifests/params.pp

@@ -50,7 +50,7 @@ class l23network::params {
       $ovs_datapath_package_name  = $::l23_os ? {
                                       /(?i)oraclelinux/ => 'kmod-openvswitch-uek',
                                       default           => 'kmod-openvswitch',
-                                   }
+                                    }
       $ovs_common_package_name    = 'openvswitch'
       $ovs_kern_module_name       = 'openvswitch'
       $network_manager_name       = 'NetworkManager'

deployment/puppet/osnailyfacter/modular/ceph/ceph_compute.pp

@@ -96,7 +96,7 @@ if $use_ceph {
     cwd  => '/root',
   }
 
-} 
+}
 
 if !($storage_hash['ephemeral_ceph']) {
   class { 'ceph::ephemeral':

deployment/puppet/vmware/Gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 group :development, :test do
   gem 'puppetlabs_spec_helper', :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'puppet-lint', '~> 1.1'
   gem 'rake', '~> 10.3.1'
 end