openstack
/
gnocchi
Code Issues Proposed changes

carbonara: rewrite lock debug statement 

There's no lock anymore so this should not be logged like that. instead, we
only LOG.debug if we successfully processed the log. The time is not useful
anymore and since log are timestamped, it can be computed if needed anyway.

Change-Id: I40d38985f7a4f3368aeeec56d2b592f64882d1f7
This commit is contained in:
Julien Danjou 2017-05-18 21:25:23 +02:00
parent c4183fe4fa
commit 11e5668e69
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gnocchi/storage/_carbonara.py
View File

@ -375,16 +375,12 @@ class CarbonaraBasedStorage(storage.StorageDriver):
for metric in metrics:
# NOTE(gordc): must lock at sack level
try:
locksw = timeutils.StopWatch().start()
LOG.debug("Processing measures for %s", metric)
with self.incoming.process_measure_for_metric(metric) \
as measures:
self._compute_and_store_timeseries(metric, measures)
LOG.debug("Metric %s locked during %.2f seconds",
metric.id, locksw.elapsed())
LOG.debug("Measures for metric %s processed", metric)
except Exception:
LOG.debug("Metric %s locked during %.2f seconds",
metric.id, locksw.elapsed())
if sync:
raise
LOG.error("Error processing new measures", exc_info=True)