From 5822c28d2261551986072db358d8cd348f890362 Mon Sep 17 00:00:00 2001 From: Doug Hellmann Date: Wed, 19 Sep 2018 14:29:31 -0400 Subject: [PATCH] tweak definition of 'review' Change-Id: I2aa413da3395ae68cda39bf97dca5322d02a355f Signed-off-by: Doug Hellmann --- goal_tools/python3_first/patches.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/goal_tools/python3_first/patches.py b/goal_tools/python3_first/patches.py index 6b5e9b3..c78d4c2 100644 --- a/goal_tools/python3_first/patches.py +++ b/goal_tools/python3_first/patches.py @@ -392,8 +392,13 @@ class PatchesCount(lister.Lister): verified_votes = count_votes(c, 'Verified') if verified_votes.get(-1) or verified_votes.get(-2): fail_counts.update(item) + # We count reviewers as anyone posting +/- 1 or +/- 2 + # votes on a patch. reviewed_votes = count_votes(c, 'Code-Review') - if not (reviewed_votes.get(-1, 0) + reviewed_votes.get(1, 0)): + reviewers = ( + sum(reviewed_votes.values()) - reviewed_votes.get(0, 0) + ) + if not reviewers: unreviewed_counts.update(item) columns = (