openstack
/
goal-tools
Code Issues Proposed changes

try again to be more robust in scanning labels 

Change-Id: I50eab29c24fdddba33a920bdfbd9f423db30dd27
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-04-30 17:50:05 -04:00
parent 37f96735d4
commit d2e2c8fb68
1 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
goal_tools/gerrit.py
View File

@ -162,31 +162,31 @@ class Review:
def reviewers(self):
labels = self._data['labels']
if 'Code-Review' in labels:
for label in labels['Code-Review']['all']:
if label['value'] not in (2, -1):
# Only report reviewers with negative reviews or
# approvals to avoid counting anyone who is just
# leaving lots of +1 votes without actually providing
# feedback.
continue
yield Participant(
'reviewer',
label['name'],
label['email'],
_to_datetime(label['date']),
)
code_review_labels = labels.get('Code-Review', {}).get('all', [])
for label in code_review_labels:
if label['value'] not in (2, -1):
# Only report reviewers with negative reviews or
# approvals to avoid counting anyone who is just
# leaving lots of +1 votes without actually providing
# feedback.
continue
yield Participant(
'reviewer',
label['name'],
label['email'],
_to_datetime(label['date']),
)
if 'Workflow' in labels:
for label in labels['Workflow']['all']:
if label.get('value', 0) != 1:
continue
yield Participant(
'approver',
label['name'],
label['email'],
_to_datetime(label['date']),
)
workflow_labels = labels.get('Workflow', {}).get('all', [])
for label in workflow_labels:
if label.get('value', 0) != 1:
continue
yield Participant(
'approver',
label['name'],
label['email'],
_to_datetime(label['date']),
)
def cache_review(review_id, data, cache):