Fix nova integration job

Running it turned up a bunch of false positives around delayed LOG
string interpolation, so we need to fix our pattern match from
`.format` to `.format(` to avoid incorrectly catching things like
`.format_message()`.

We also add the E checks in the Nova integration tests. As we saw in
the previous commit, sometimes flake8 gets bugs that caused things
that would normally get flagged to not actually get flagged, like
lines longer than 80 chars in docstrings. By running Nova
integration with E, we make sure any such changes are caught ahead of
time.

Depends-on: https://review.opendev.org/c/openstack/nova/+/874517
Change-Id: I236a25e5380b5492009d587e76347e52ec50c09f
This commit is contained in:
Artom Lifshitz 2023-02-20 13:45:15 -05:00 committed by Dr. Jens Harbott
parent 8d0a4a1874
commit 7868295f9b
2 changed files with 2 additions and 2 deletions

View File

@ -18,4 +18,4 @@
- openstack/nova
vars:
tox_envlist: integration
tox_extra_args: -vv openstack nova {{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/nova'].src_dir }}
tox_extra_args: -- openstack nova {{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/nova'].src_dir }}

View File

@ -47,7 +47,7 @@ pip install .
# Reinstall hacking, the above might have uninstalled it
pip install $HACKING
flake8 --select H --statistics
flake8 --select E,H --statistics
RET=$?
popd