Update patch set 1
Patch Set 1: (14 comments) Patch-set: 1
This commit is contained in:
Gerrit User 12404
Gerrit Code Review
parent
5b229ccee4
commit
556b284aea
|
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_2f9af512",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_4484f80b",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 26,
|
||||
"endLine": 33,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_24945c36",
|
||||
|
|
@ -46,6 +70,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_8f9549e6",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 39,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_24945c36",
|
||||
"range": {
|
||||
"startLine": 39,
|
||||
"startChar": 0,
|
||||
"endLine": 39,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_a4994c7b",
|
||||
|
|
@ -69,6 +117,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_8fc78912",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 47,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "barbican client accept a secret_ref to get secret which is Full HATEOAS reference to a Secret like ``http://192.168.1.101/key-manager/v1/secrets/55fcc88c-2926-47f3-b23b-6c5e2a818933``\n\nhttps://github.com/openstack/python-barbicanclient/blob/master/barbicanclient/v1/secrets.py#L447",
|
||||
"parentUuid": "5f7c97a3_a4994c7b",
|
||||
"range": {
|
||||
"startLine": 47,
|
||||
"startChar": 14,
|
||||
"endLine": 47,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_6426d425",
|
||||
|
|
@ -92,6 +164,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0ad5a747",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 67,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "see comment in line 98",
|
||||
"parentUuid": "5f7c97a3_6426d425",
|
||||
"range": {
|
||||
"startLine": 65,
|
||||
"startChar": 0,
|
||||
"endLine": 67,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0437e04d",
|
||||
|
|
@ -115,6 +211,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_2fb3d59c",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 70,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_0437e04d",
|
||||
"range": {
|
||||
"startLine": 70,
|
||||
"startChar": 46,
|
||||
"endLine": 70,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0465a049",
|
||||
|
|
@ -149,6 +269,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_6f478d7c",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_4f573103",
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_efa95dde",
|
||||
|
|
@ -172,6 +310,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_ea64ebe8",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "We always get the newest secret, we only store the credential(secret herf). if user like to rotate the credential(secret herf), they can use stack update\n\nWhen we do action like stack delete, we can\u0027t force user to give a new secret herf",
|
||||
"parentUuid": "5f7c97a3_efa95dde",
|
||||
"range": {
|
||||
"startLine": 92,
|
||||
"startChar": 0,
|
||||
"endLine": 92,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_8fe9c91a",
|
||||
|
|
@ -189,6 +351,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_2aee6321",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 98,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "I parse credential in remote site, so we have to know where is the remote side(that\u0027s why we need provider).\n\nBut what we can improve it use a barbican secret for cloud_provider information so we can have another option to let user put config by themself",
|
||||
"parentUuid": "5f7c97a3_8fe9c91a",
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_4ff3b10a",
|
||||
|
|
@ -212,6 +392,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0abe0700",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 101,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_4ff3b10a",
|
||||
"range": {
|
||||
"startLine": 101,
|
||||
"startChar": 17,
|
||||
"endLine": 101,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0fd5b947",
|
||||
|
|
@ -235,6 +439,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_4aab9f87",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 103,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Barbican Secret can manage who will be able to get/list/... secret so since that secret going to be used to orchestrate resources, it should aware that other user in the same remote project can\u0027t load that secret from barbican. Otherwise that user can run a stack delete and destroy all resources.",
|
||||
"parentUuid": "5f7c97a3_0fd5b947",
|
||||
"range": {
|
||||
"startLine": 102,
|
||||
"startChar": 10,
|
||||
"endLine": 103,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_afe1252e",
|
||||
|
|
@ -258,6 +486,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_2a3c2391",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 105,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_afe1252e",
|
||||
"range": {
|
||||
"startLine": 105,
|
||||
"startChar": 25,
|
||||
"endLine": 105,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0f6cd99b",
|
||||
|
|
@ -275,6 +527,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_aa4fd333",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 109,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "got it",
|
||||
"parentUuid": "5f7c97a3_0f6cd99b",
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_af1605f2",
|
||||
|
|
@ -298,6 +568,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_ca4c8f41",
|
||||
"filename": "specs/rocky/multi-cloud-support.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 115,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f7c97a3_af1605f2",
|
||||
"range": {
|
||||
"startLine": 115,
|
||||
"startChar": 59,
|
||||
"endLine": 115,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_2fb19502",
|
||||
|
|
@ -348,6 +642,24 @@
|
|||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_caa48fa6",
|
||||
"filename": "specs/rocky/rocky-template.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-06-27T18:23:24Z",
|
||||
"side": 1,
|
||||
"message": "sure, will update this part later",
|
||||
"parentUuid": "5f7c97a3_b8965549",
|
||||
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue