openstack
/
heat-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
Label: Verified=0
This commit is contained in:
Gerrit User 12404 2018-06-29 06:59:39 +00:00 committed by Gerrit Code Review
parent bbe1b4d2dd
commit 69349c0d44
1 changed files with 84 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
5b104c92e9fc3e18623c0d943c54327c879380d5
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_f174bf06",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 4
},
"lineNbr": 48,
"author": {
"id": 12404
},
"writtenOn": "2018-06-29T06:59:39Z",
"side": 1,
"message": "To formalized what we needs from Barbican secret, I adopt same format as credential(credential_secret_id).\nIt will contains auth_type and auth(which contains auth_url)\nIn this sense, I call it with provider credential. Any better name than that?:)\n\nI changed this key to ``provider_credential_secret_id``",
"parentUuid": "5f7c97a3_0d75a500",
"revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_0dc36508",
@ -40,6 +58,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_31e0f797",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 4
},
"lineNbr": 60,
"author": {
"id": 12404
},
"writtenOn": "2018-06-29T06:59:39Z",
"side": 1,
"message": "why would people try to directly put secrets on?:)\ncredential_secret_id works for me",
"parentUuid": "5f7c97a3_0dc36508",
"range": {
"startLine": 60,
"startChar": 6,
"endLine": 60,
"endChar": 16
},
"revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_8d68d522",
@ -63,6 +105,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_0d6cb7ce",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 4
},
"lineNbr": 68,
"author": {
"id": 12404
},
"writtenOn": "2018-06-29T06:59:39Z",
"side": 1,
"message": "removed",
"parentUuid": "5f7c97a3_8d68d522",
"range": {
"startLine": 68,
"startChar": 0,
"endLine": 68,
"endChar": 56
},
"revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_0d5e0579",
@ -102,6 +168,24 @@
"revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_cd655fe4",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 4
},
"lineNbr": 76,
"author": {
"id": 12404
},
"writtenOn": "2018-06-29T06:59:39Z",
"side": 1,
"message": "Done",
"parentUuid": "5f7c97a3_6da4594c",
"revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}