Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1

7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff

@@ -238,6 +238,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "5f7c97a3_aa406e33",
+        "filename": "specs/rocky/vitrage-resources.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 84,
+      "author": {
+        "id": 19159
+      },
+      "writtenOn": "2018-07-08T13:45:53Z",
+      "side": 1,
+      "message": "\u003e If it\u0027s not a huge burden, I do prefer we go with option 1. that\n \u003e way, ops get more flex on the range of instances. Also we get to\n \u003e define this vitrage template resource within that Stack template\n \u003e \n \u003e And we can also create a auto-scaling group on top of a\n \u003e auto-healing template (vitrage+instance+mistral) like what you see\n \u003e in heat-template\n \nOk, I changed it.\n \n \u003e So maybe we can add one more property call `template_type` and\n \u003e currently only allow `self-healing-instance`(or some better name ;)\n \u003e )? So once we add more kind of support, It won\u0027t conflict or\n \u003e backport imcompatabile.\n\nI added \u0027type\u0027, although I\u0027m not so sure it\u0027s the right direction. We did not yet design how it will work in Vitrage in phase 2, so I\u0027m not 100% sure that we will create a template by a type parameter. On the other hand, I really want to push something in Rocky, even as a POC. What is the impact of changing some of the properties later on, in Stein? (hopefully we won\u0027t need to do that, but still)\n\nAnd thinking of what you said, I decided to add some more specific properties, that will also allow us in the future to generate templates that perform other actions, not only execute_mistral.\n\n \u003e \u003e It might also be a good idea to\n \u003e \u003e define a property for \u0027execute_workflow\u0027 that holds the\n \u003e workflow_id\n \u003e \u003e and workflow_input inside.\n \u003e \n \u003e That\u0027s good idea:)\n\nDone",
+      "parentUuid": "5f7c97a3_783499ac",
+      "range": {
+        "startLine": 84,
+        "startChar": 10,
+        "endLine": 84,
+        "endChar": 46
+      },
+      "revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5f7c97a3_0e84685c",
@@ -272,6 +296,24 @@
       "revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_0a52c212",
+        "filename": "specs/rocky/vitrage-resources.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 128,
+      "author": {
+        "id": 19159
+      },
+      "writtenOn": "2018-07-08T13:45:53Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5f7c97a3_f13463ae",
+      "revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }