Update patch set 5
Abandoned Patch-set: 5 Status: abandoned Tag: autogenerated:gerrit:abandon
This commit is contained in:
Gerrit User 10487
Gerrit Code Review
parent
aee997072d
commit
959e425f5c
|
|
@ -1,6 +1,7 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3a961159_fa37fcad",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -14,10 +15,10 @@
|
|||
"side": 1,
|
||||
"message": "not sure I understand this correctly. Are you suggesting adopt to migrate a resource from one stack to another? Or how (considering the command line below) would the properties of a newly adopted resource be populated? Shouldn\u0027t there be some sort of input data structure describing properties? Related to that - how Heat will now which type of resource is that only be physical_resource_id?",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3a961159_c6c6d89b",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -32,10 +33,10 @@
|
|||
"message": "This blueprint helps to adopt/abandon a resource for a stack, but does not support the migration from one stack to another directly(ofcourse this can be done by abandon from one stack and adopt to another stack)\n\nIn the given template, let us say there is an resource \u0027A\u0027 of type \u0027instance\u0027 and for that resource, user wants to adopt an existing instance. So user could provide the \u0027physical resoruce id\u0027 of the existing instance and heat should be able to accomedate that instance for resource A, here resource type is already identified as \u0027instance\u0027 as part of template definition. \n\nRegarding additional properties, we need to see the use case for it and add the support for the same accordingly.(there is an another blueprint \u0027add external resource support\u0027.",
|
||||
"parentUuid": "3a961159_fa37fcad",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fa32b979_a1fb1178",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -49,10 +50,10 @@
|
|||
"side": 1,
|
||||
"message": "I think there needs to be an resource-export action as well. Otherwise, we\u0027ll have the same problem with this feature that exists in the stack-abandon/adopt feature: https://bugs.launchpad.net/heat/+bug/1353670",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fa32b979_61861ebb",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -67,10 +68,10 @@
|
|||
"message": "sure. I will update it",
|
||||
"parentUuid": "fa32b979_a1fb1178",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3a961159_5a43b012",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -84,10 +85,10 @@
|
|||
"side": 1,
|
||||
"message": "surely at least kilo-2",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3a961159_06c46090",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -102,10 +103,10 @@
|
|||
"message": "yes, this should be kilo-3",
|
||||
"parentUuid": "3a961159_5a43b012",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fa32b979_e1c0eee2",
|
||||
"filename": "specs/kilo/heat-adopt-deadopt-resource.rst",
|
||||
|
|
@ -120,8 +121,84 @@
|
|||
"message": "I will update to liberty 3",
|
||||
"parentUuid": "3a961159_06c46090",
|
||||
"revId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
],
|
||||
"submitRequirementResults": [
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Code-Review",
|
||||
"description": {
|
||||
"value": "Code reviewed by core reviewer"
|
||||
},
|
||||
"applicabilityExpression": {},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Verified",
|
||||
"description": {
|
||||
"value": "Verified in gate by CI"
|
||||
},
|
||||
"applicabilityExpression": {},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Workflow",
|
||||
"description": {
|
||||
"value": "Approved for gate by core reviewer"
|
||||
},
|
||||
"applicabilityExpression": {},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MIN"],"failingAtoms":["label:Workflow=MAX"]}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "4f73d2be35cf0c79d5b717c8d4bad8260199c8cb",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue