Update patch set 1

Patch Set 1:

(3 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 12404 2018-06-28 05:46:31 +00:00 committed by Gerrit Code Review
parent 3c05e61d7c
commit a17875e249
1 changed files with 66 additions and 0 deletions

View File

@ -165,6 +165,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_c9f0136a",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 1
},
"lineNbr": 47,
"author": {
"id": 12404
},
"writtenOn": "2018-06-28T05:46:31Z",
"side": 1,
"message": "Seems Barbican can also accept `secrets/SECRET_ID` as input, so I changed my implementation to only allow pass around and store the secret ID. Once Barbican change that format, we can remove the prefix (`secrets/`)(if that ML gonna trigger someone to do it)",
"parentUuid": "5f7c97a3_6aebfb7a",
"range": {
"startLine": 47,
"startChar": 14,
"endLine": 47,
"endChar": 18
},
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_6426d425",
@ -382,6 +406,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_496c039d",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 12404
},
"writtenOn": "2018-06-28T05:46:31Z",
"side": 1,
"message": "The unit test is wrong, and I fixed it now(thx for finding it)\n\nthe ID is stored in properties for resource, which will not pass around when we try to delete the stack.\nNot sure the reason for it but if it\u0027s better, we can try to pass that from resource property to every Stack commands. But that means we will try to add `credential` arg for must of stack action ( includes POST/GET/PATCH/DELETE I assume) and also change client",
"parentUuid": "5f7c97a3_6a2c5bb2",
"range": {
"startLine": 92,
"startChar": 0,
"endLine": 92,
"endChar": 25
},
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_8fe9c91a",
@ -716,6 +764,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_89e77be4",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 1
},
"lineNbr": 137,
"author": {
"id": 12404
},
"writtenOn": "2018-06-28T05:46:31Z",
"side": 1,
"message": "It stores stack_id, and credential(Barbican secret ID).\nAnd why not!?:)",
"parentUuid": "5f7c97a3_efcabd6d",
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_b8965549",