openstack
/
heat-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 19159 2018-07-04 08:38:00 +00:00 committed by Gerrit Code Review
parent 6f706e46ef
commit c9526ea84f
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff
View File

@ -94,6 +94,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_042e7bf9",
"filename": "specs/rocky/vitrage-resources.rst",
"patchSetId": 1
},
"lineNbr": 84,
"author": {
"id": 19159
},
"writtenOn": "2018-07-04T08:38:00Z",
"side": 1,
"message": "You removed stack_id from the properties, and renamed the one under workflow_input. Were these your only changes, or am I missing something?\n\nI wrote the stack_id in two places, because it is needed both for Vitrage template and as an input to the Mistral workflow. It won\u0027t necessarily have the same name. If I understand correctly, the property under workflow_input is not predefined in the code, so it could be anything.",
"parentUuid": "5f7c97a3_a4a467b9",
"range": {
"startLine": 84,
"startChar": 10,
"endLine": 84,
"endChar": 46
},
"revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_0e84685c",