openstack
/
horizon
Code Issues Proposed changes

Angular pages will reload if collapse/expand sidebar 

use ng-images as example to explan the issue:
1.enable ng-images page and go into this page.
2.click left sidebar to collapse/expand a dashboard or panel-group
3.the url change to "project/ngimages/#sidebar-accordion-***" which
  match the route[1]. Current page will reload even it's not change.

Use "data-target" instead of "href" to fix it. ref:[2]

[1]https://github.com/openstack/horizon/blob/master/
openstack_dashboard/static/app/core/images/images.module.js#L190
[2]https://github.com/openstack/xstatic-bootstrap-scss/blob/
master/xstatic/pkg/bootstrap_scss/data/js/bootstrap.js#L505

Change-Id: I1c84c6af49a67bf2833ad5b0103f6cbd4abd0ddb
Closes-Bug: #1543327
This commit is contained in:
wangbo 2016-05-17 15:12:40 +08:00
parent ea8e7a504a
commit 18b351b9c4
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
horizon/templates/horizon/_sidebar.html
View File

@ -6,7 +6,8 @@
<li class="panel openstack-dashboard{% if current.slug == dashboard.slug %} active{% endif %}">
<a data-toggle="collapse"
data-parent="#sidebar-accordion"
href="#sidebar-accordion-{{ dashboard.slug }}"
data-target="#sidebar-accordion-{{ dashboard.slug }}"
href="javascript:;"
{% if current.slug != dashboard.slug %}
class="collapsed"
{% endif %}>
@ -22,7 +23,8 @@
<li class="nav-header panel">
<a data-toggle="collapse"
data-parent="#sidebar-accordion-{{ dashboard.slug }}"
href="#sidebar-accordion-{{ dashboard.slug }}-{{ group.slug }}"
data-target="#sidebar-accordion-{{ dashboard.slug }}-{{ group.slug }}"
href="javascript:;"
{% if current.slug == dashboard.slug and current_panel_group != group.slug %}class="collapsed"
{% elif current.slug != dashboard.slug and forloop.counter0 != 0 %}class="collapsed"{% endif %}>
<span class="nav-header-title">

6
openstack_dashboard/themes/material/templates/horizon/_sidebar.html
View File

@ -7,7 +7,8 @@
<li class="openstack-dashboard{% if current.slug == dashboard.slug %} active{% endif %}">
<a data-toggle="collapse"
data-parent="#sidebar-drawer"
href="#sidebar-drawer-{{ dashboard.slug }}"
data-target="#sidebar-drawer-{{ dashboard.slug }}"
href="javascript:;"
{% if current.slug != dashboard.slug %}
class="collapsed"
{% endif %}>
@ -23,7 +24,8 @@
<li class="nav-header">
<a data-toggle="collapse"
data-parent="#sidebar-drawer-{{ dashboard.slug }}"
href="#sidebar-drawer-{{ dashboard.slug }}-{{ group.slug }}"
data-target="#sidebar-drawer-{{ dashboard.slug }}-{{ group.slug }}"
href="javascript:;"
{% if current.slug == dashboard.slug and current_panel_group != group.slug %}class="collapsed"
{% elif current.slug != dashboard.slug and forloop.counter0 != 0 %}class="collapsed"{% endif %}>
<span class="nav-header-title">