openstack
/
horizon
Code Issues Proposed changes

Ensure tox registers failures properly 

Tox runs tests via unit_tests.sh which when not
running a test subset will mean tox only checks for
the final exit code. This means horizon test failues
will not be seen by tox unless openstack_dashboard
tests also fail.

This change forces an exit code which !=0 if either
test run fails.

Change-Id: I8fbcb834d9817e7eea1b2c39fc4caab6004b981b
This commit is contained in:
adrian-turjak 2017-07-20 01:42:20 +12:00 committed by Adrian Turjak
parent 79a3c65f4a
commit 280848c55f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/unit_tests.sh
View File

@ -25,6 +25,12 @@ if [ -n "$subset" ]; then
fi
else
$testcommand horizon --settings=horizon.test.settings $posargs
horizon_tests=$?
$testcommand openstack_dashboard --settings=openstack_dashboard.test.settings \
--exclude-dir=openstack_dashboard/test/integration_tests $posargs
openstack_dashboard_tests=$?
# we have to tell tox if either of these test runs failed
if [[ $horizon_tests != 0 || $openstack_dashboard_tests != 0 ]]; then
exit 1;
fi
fi