openstack
/
horizon
Code Issues Proposed changes

elif replace if 

3 'if' at same levels and each 'if' has 'return',
in this case, elif is better than if.
more readable, more effective.

Change-Id: Ib0528ab69679f320f1580971945ce36eaaedf011
Signed-off-by: peiy <peiy@rc.inesa.com>
This commit is contained in:
peiy 2018-01-19 15:33:05 +08:00
parent c5901fe34c
commit 42fe004c30
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_dashboard/api/nova.py
View File

@ -134,9 +134,9 @@ class Server(base.APIResourceWrapper):
if not self.image:
return None
if hasattr(self.image, 'name'):
elif hasattr(self.image, 'name'):
return self.image.name
if 'name' in self.image:
elif 'name' in self.image:
return self.image['name']
else:
try: