From 4e52904000dc1a01fb4e513a58d2b05e2f3b02eb Mon Sep 17 00:00:00 2001 From: Michael Krotscheck Date: Mon, 23 Nov 2015 10:36:05 -0800 Subject: [PATCH] Enable semi-spacing This patch enables the "semi-spacing" rule from eslint-config-openstack, and corrects any errors found. http://eslint.org/docs/rules/semi-spacing Change-Id: Ib6a2d856f24b53b24c65c4165cec92a7c1428832 --- .eslintrc | 1 - horizon/static/framework/widgets/modal/simple-modal.spec.js | 2 +- .../openstack-service-api/cinder-extensions.service.spec.js | 4 ++-- .../openstack-service-api/nova-extensions.service.spec.js | 4 ++-- .../openstack-service-api/service-catalog.service.spec.js | 4 ++-- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.eslintrc b/.eslintrc index b77f85c847..d8b07c2b1b 100644 --- a/.eslintrc +++ b/.eslintrc @@ -32,7 +32,6 @@ rules: callback-return: 1 guard-for-in: 1 block-scoped-var: 1 - semi-spacing: 1 no-redeclare: 1 no-new: 1 diff --git a/horizon/static/framework/widgets/modal/simple-modal.spec.js b/horizon/static/framework/widgets/modal/simple-modal.spec.js index 2b4794abdd..4875c42e83 100644 --- a/horizon/static/framework/widgets/modal/simple-modal.spec.js +++ b/horizon/static/framework/widgets/modal/simple-modal.spec.js @@ -70,7 +70,7 @@ var service, modal; beforeEach(module(function($provide) { - modal = { open: function() {return 'val';} }; + modal = { open: function() {return 'val'; } }; $provide.value('$modal', modal); })); diff --git a/openstack_dashboard/static/app/core/openstack-service-api/cinder-extensions.service.spec.js b/openstack_dashboard/static/app/core/openstack-service-api/cinder-extensions.service.spec.js index a13d19807e..63062b8321 100644 --- a/openstack_dashboard/static/app/core/openstack-service-api/cinder-extensions.service.spec.js +++ b/openstack_dashboard/static/app/core/openstack-service-api/cinder-extensions.service.spec.js @@ -21,9 +21,9 @@ beforeEach(module('horizon.app.core.openstack-service-api')); beforeEach(module(function($provide) { - cinderAPI = {getExtensions: function() {return {then: angular.noop};}}; + cinderAPI = {getExtensions: function() {return {then: angular.noop}; }}; q = {defer: function() { return {resolve: angular.noop}; }}; - $provide.value('$cacheFactory', function() {return "cache";}); + $provide.value('$cacheFactory', function() {return "cache"; }); $provide.value('$q', q); $provide.value('horizon.app.core.openstack-service-api.cinder', cinderAPI); })); diff --git a/openstack_dashboard/static/app/core/openstack-service-api/nova-extensions.service.spec.js b/openstack_dashboard/static/app/core/openstack-service-api/nova-extensions.service.spec.js index 7714b5d68f..d97943392e 100644 --- a/openstack_dashboard/static/app/core/openstack-service-api/nova-extensions.service.spec.js +++ b/openstack_dashboard/static/app/core/openstack-service-api/nova-extensions.service.spec.js @@ -23,9 +23,9 @@ beforeEach(module('horizon.app.core.openstack-service-api')); beforeEach(module(function($provide) { - novaAPI = {getExtensions: function() {return {then: angular.noop};}}; + novaAPI = {getExtensions: function() {return {then: angular.noop}; }}; q = {defer: function() { return {resolve: angular.noop}; }}; - $provide.value('$cacheFactory', function() {return "cache";}); + $provide.value('$cacheFactory', function() {return "cache"; }); $provide.value('$q', q); $provide.value('horizon.app.core.openstack-service-api.nova', novaAPI); })); diff --git a/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.spec.js b/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.spec.js index cf9c9fecf5..8dd20e5fe9 100644 --- a/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.spec.js +++ b/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.spec.js @@ -28,8 +28,8 @@ userSession = {get: angular.noop}; $provide.value('horizon.app.core.openstack-service-api.userSession', userSession); deferred = {promise: angular.noop, reject: angular.noop, resolve: angular.noop}; - q = {all: function() {return {then: angular.noop};}, - defer: function() { return deferred;}}; + q = {all: function() {return {then: angular.noop}; }, + defer: function() { return deferred; }}; $provide.value('$q', q); $provide.value('$cacheFactory', function() { return 'cache'; }); }));