From fdc17c5677b2ad6312c38b2f4f186bbbc16a6555 Mon Sep 17 00:00:00 2001
From: Diana Whitten <hurgleburgler@gmail.com>
Date: Wed, 29 Jun 2016 14:37:24 -0700
Subject: [PATCH] Containers/Swift has unneccesary padding

* Added themable checkboxes so that all the checkboxes
  are now consistent.  There was already a single themable
  one in the contain detail view

* Removed unneccesary padding around swift breadcrumb

* Added themable checkboxes to hz-table

* Replaced 'empty table' with bootstrap well, which works
  quite well for this type of implememtation.

Closes-bug: #1597532
Change-Id: Ifff3f608d309ef0bd926c553be0a3a0e1d419096
---
 .../framework/widgets/table/hz-dynamic-table.html | 15 +++++++++++----
 .../dashboard/project/containers/_containers.scss |  9 +++++++++
 .../containers/create-container-modal.html        |  6 +++---
 .../project/containers/select-container.html      | 13 ++++++-------
 .../themes/material/static/horizon/_icons.scss    |  1 +
 5 files changed, 30 insertions(+), 14 deletions(-)

diff --git a/horizon/static/framework/widgets/table/hz-dynamic-table.html b/horizon/static/framework/widgets/table/hz-dynamic-table.html
index 78ed53dc8e..a68217b2b9 100644
--- a/horizon/static/framework/widgets/table/hz-dynamic-table.html
+++ b/horizon/static/framework/widgets/table/hz-dynamic-table.html
@@ -28,7 +28,10 @@
         -->
         <tr>
           <th ng-show="config.selectAll" class="multi_select_column">
-            <input type="checkbox" hz-select-all="items">
+            <div class="themable-checkbox">
+              <input type="checkbox" id="hz-table-select-all" hz-select-all="items">
+              <label for="hz-table-select-all"></label>
+            </div>
           </th>
           <th ng-show="config.expand" class="expander"></th>
           <th ng-repeat="column in config.columns"
@@ -51,9 +54,13 @@
             ng-class="{'st-selected': checked[item[config.trackId]]}">
 
           <td ng-show="config.selectAll" class="multi_select_column">
-            <input type="checkbox"
-              ng-model="tCtrl.selections[item[config.trackId]].checked"
-              hz-select="item">
+            <div class="themable-checkbox">
+              <input type="checkbox"
+                     id="{$ item[config.trackId] $}"
+                     ng-model="tCtrl.selections[item[config.trackId]].checked"
+                     hz-select="item">
+              <label for="{$ item[config.trackId] $}"></label>
+            </div>
           </td>
           <td ng-show="config.expand" class="expander">
             <span class="fa fa-chevron-right"
diff --git a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/_containers.scss b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/_containers.scss
index 2a4bd9c924..436d3d13d3 100644
--- a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/_containers.scss
+++ b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/_containers.scss
@@ -91,6 +91,15 @@
       content: ":";
     }
   }
+
+  &,
+  & > li {
+    margin-top: 0;
+  }
+}
+
+.hz-object-empty {
+  margin-top: 0;
 }
 
 .hz-object-detail {
diff --git a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/create-container-modal.html b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/create-container-modal.html
index 447137d66e..cc60a50f34 100644
--- a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/create-container-modal.html
+++ b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/create-container-modal.html
@@ -25,10 +25,10 @@
           </div>
           <div class="form-group">
             <label class="control-label" translate>Container Access</label>
-            <div>
+            <div class="themable-checkbox">
+              <input type="checkbox" ng-model="ctrl.model.public"
+                     name="public" checked id="id_public">
               <label for="id_public">
-                <input type="checkbox" ng-model="ctrl.model.public"
-                        name="public" checked id="id_public">
                 <span translate>Public</span>
               </label>
             </div>
diff --git a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/select-container.html b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/select-container.html
index 0d20e8ba5d..4a09460dd8 100644
--- a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/select-container.html
+++ b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/select-container.html
@@ -1,7 +1,6 @@
-<table class="table table-bordered tablestriped">
-  <tbody>
-    <tr class="odd empty">
-      <td><translate>Select a container to browse.</translate></td>
-    </tr>
-  </tbody>
-</table>
+<div>
+  <div class="well text-center h4 hz-object-empty">
+    <span class="fa fa-info-circle"></span>
+    <span translate>Select a container to browse.</span>
+  </div>
+</div>
diff --git a/openstack_dashboard/themes/material/static/horizon/_icons.scss b/openstack_dashboard/themes/material/static/horizon/_icons.scss
index e1a119e3da..68bab57c02 100644
--- a/openstack_dashboard/themes/material/static/horizon/_icons.scss
+++ b/openstack_dashboard/themes/material/static/horizon/_icons.scss
@@ -44,6 +44,7 @@ $icon-swap: (
   folder-o: 'folder-outline',
   group: 'account-multiple',
   home: 'home',
+  info-circle: 'information-outline',
   link: 'link-variant',
   list-alt: 'view-list',
   minus: 'minus',