openstack
/
horizon
Code Issues Proposed changes

pytest-based selenium tests : Add image pagination and admin tests 

Change-Id: I512efb56251b1c7a3f206e1f1fba2863b30a608f
This commit is contained in:
Ashish Gupta 2023-11-27 22:05:42 +05:30
parent 12644333d5
commit b3ddd9d168
2 changed files with 215 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

228
openstack_dashboard/test/selenium/integration/test_images.py
View File

@ -20,50 +20,80 @@ from oslo_utils import uuidutils
from openstack_dashboard.test.selenium import widgets
@pytest.fixture
def image_name():
return 'horizon_image_%s' % uuidutils.generate_uuid(dashed=False)
@pytest.fixture(params=[1])
def image_names(request):
count = request.param
img_name_list = ['horizon_img_%s' % uuidutils.generate_uuid(dashed=False)]
if count > 1:
img_name_list = [f"{img_name_list[0]}-{item}"
for item in range(1, count + 1)]
return img_name_list
@pytest.fixture
def new_image_demo(image_name, temporary_file, openstack_demo):
image = openstack_demo.create_image(
image_name,
disk_format="qcow2",
filename=temporary_file,
wait=True,
)
def new_image_demo(image_names, temporary_file, openstack_demo):
for img in image_names:
image = openstack_demo.create_image(
img,
disk_format="qcow2",
filename=temporary_file,
wait=True,
)
yield image
openstack_demo.delete_image(image_name)
for img in image_names:
openstack_demo.delete_image(img)
@pytest.fixture
def clear_image_demo(image_name, openstack_demo):
def new_image_admin(image_names, temporary_file, openstack_admin):
for img in image_names:
image = openstack_admin.create_image(
img,
disk_format="qcow2",
filename=temporary_file,
wait=True,
)
yield image
for img in image_names:
openstack_admin.delete_image(img)
@pytest.fixture
def clear_image_demo(image_names, openstack_demo):
yield None
openstack_demo.delete_image(
image_name,
wait=True,
)
for img in image_names:
openstack_demo.delete_image(
img,
wait=True,
)
@pytest.fixture
def temporary_file(tmp_path, name='', suffix='.qcow2', size=5000):
"""Generate temporary file with provided parameters.
def clear_image_admin(image_names, openstack_admin):
yield None
for img in image_names:
openstack_admin.delete_image(
img,
wait=True,
)
@pytest.fixture
def temporary_file(tmp_path):
"""Generate temporary file.
:param name: file name except the extension /suffix
:param suffix: file extension/suffix
:param size: size of the file to create, bytes are generated randomly
:return: path to the generated file
"""
with tempfile.NamedTemporaryFile(prefix=name, suffix=suffix,
with tempfile.NamedTemporaryFile(suffix='.qcow2',
dir=tmp_path) as tmp_file:
tmp_file.write(os.urandom(size))
tmp_file.write(os.urandom(5000))
yield tmp_file.name
def test_image_create_from_local_file_demo(login, driver, image_name,
def test_image_create_from_local_file_demo(login, driver, image_names,
temporary_file, clear_image_demo,
config, openstack_demo):
image_name = image_names[0]
login('user', 'demo')
url = '/'.join((
config.dashboard.dashboard_url,
@ -88,8 +118,9 @@ def test_image_create_from_local_file_demo(login, driver, image_name,
assert openstack_demo.compute.find_image(image_name) is not None
def test_image_delete_demo(login, driver, image_name, openstack_demo,
def test_image_delete_demo(login, driver, image_names, openstack_demo,
new_image_demo, config):
image_name = image_names[0]
login('user', 'demo')
url = '/'.join((
config.dashboard.dashboard_url,
@ -106,3 +137,150 @@ def test_image_delete_demo(login, driver, image_name, openstack_demo,
messages = widgets.get_and_dismiss_messages(driver)
assert f"Success: Deleted Image: {image_name}." in messages
assert openstack_demo.compute.find_image(image_name) is None
@pytest.mark.parametrize('image_names', [2], indirect=True)
def test_image_pagination_demo(login, driver, image_names, openstack_demo,
change_page_size_demo, new_image_demo, config):
items_per_page = 1
img_list = sorted([item["name"]
for item in openstack_demo.compute.images()])
first_page_definition = widgets.TableDefinition(next=True, prev=False,
count=items_per_page,
names=[img_list[0]])
second_page_definition = widgets.TableDefinition(next=True, prev=True,
count=items_per_page,
names=[img_list[1]])
third_page_definition = widgets.TableDefinition(next=False, prev=True,
count=items_per_page,
names=[img_list[2]])
login('user', 'demo')
url = '/'.join((
config.dashboard.dashboard_url,
'project',
'images',
))
driver.get(url)
actual_page1_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert first_page_definition == actual_page1_definition
# Turning to next page(page2)
driver.find_element_by_link_text("Next »").click()
actual_page2_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert second_page_definition == actual_page2_definition
# Turning to next page(page3)
driver.find_element_by_link_text("Next »").click()
actual_page3_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert third_page_definition == actual_page3_definition
# Turning back to previous page(page2)
driver.find_element_by_link_text("« Prev").click()
actual_page2_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert second_page_definition == actual_page2_definition
# Turning back to previous page(page1)
driver.find_element_by_link_text("« Prev").click()
actual_page1_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert first_page_definition == actual_page1_definition
# Admin tests
def test_image_create_from_local_file_admin(login, driver, image_names,
temporary_file, clear_image_admin,
config, openstack_admin):
image_name = image_names[0]
login('admin', 'admin')
url = '/'.join((
config.dashboard.dashboard_url,
'project',
'images',
))
driver.get(url)
driver.find_element_by_xpath(
"//button[normalize-space()='Create Image']").click()
wizard = driver.find_element_by_css_selector("wizard")
wizard.find_element_by_id("imageForm-name").send_keys(image_name)
select_element = wizard.find_element_by_css_selector(
"input[name='image_file']")
select_element.send_keys(temporary_file)
wizard.find_element_by_id("imageForm-format").click()
wizard.find_element_by_css_selector(
"[label='QCOW2 - QEMU Emulator']").click()
wizard.find_element_by_css_selector("button.btn-primary.finish").click()
messages = widgets.get_and_dismiss_messages(driver)
assert(f"Success: Image {image_name} was successfully"
f" created." in messages)
assert openstack_admin.compute.find_image(image_name) is not None
def test_image_delete_admin(login, driver, image_names, openstack_admin,
new_image_admin, config):
image_name = image_names[0]
login('admin', 'admin')
url = '/'.join((
config.dashboard.dashboard_url,
'project',
'images',
))
driver.get(url)
rows = driver.find_elements_by_xpath(f"//a[text()='{image_name}']")
assert len(rows) == 1
actions_column = rows[0].find_element_by_xpath(
".//ancestor::tr/td[contains(@class,'actions_column')]")
widgets.select_from_dropdown(actions_column, "Delete Image")
widgets.confirm_modal(driver)
messages = widgets.get_and_dismiss_messages(driver)
assert f"Success: Deleted Image: {image_name}." in messages
assert openstack_admin.compute.find_image(image_name) is None
@pytest.mark.parametrize('image_names', [2], indirect=True)
def test_image_pagination_admin(login, driver, image_names, openstack_admin,
change_page_size_admin, new_image_admin,
config):
items_per_page = 1
img_list = sorted([item["name"]
for item in openstack_admin.compute.images()])
first_page_definition = widgets.TableDefinition(next=True, prev=False,
count=items_per_page,
names=[img_list[0]])
second_page_definition = widgets.TableDefinition(next=True, prev=True,
count=items_per_page,
names=[img_list[1]])
third_page_definition = widgets.TableDefinition(next=False, prev=True,
count=items_per_page,
names=[img_list[2]])
login('admin', 'admin')
url = '/'.join((
config.dashboard.dashboard_url,
'project',
'images',
))
driver.get(url)
actual_page1_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert first_page_definition == actual_page1_definition
# Turning to next page(page2)
driver.find_element_by_link_text("Next »").click()
actual_page2_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert second_page_definition == actual_page2_definition
# Turning to next page(page3)
driver.find_element_by_link_text("Next »").click()
actual_page3_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert third_page_definition == actual_page3_definition
# Turning back to previous page(page2)
driver.find_element_by_link_text("« Prev").click()
actual_page2_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert second_page_definition == actual_page2_definition
# Turning back to previous page(page1)
driver.find_element_by_link_text("« Prev").click()
actual_page1_definition = widgets.get_image_table_definition(driver,
sorting=True)
assert first_page_definition == actual_page1_definition

14
openstack_dashboard/test/selenium/widgets.py
View File

@ -88,10 +88,20 @@ def is_prev_link_available(driver):
def get_table_definition(driver, sorting=False):
names = driver.find_elements_by_css_selector('table tr td:nth-child(2)')
rows = driver.find_elements_by_css_selector("tr[data-display-key='name']")
if sorting:
names.sort()
actual_table = TableDefinition(next=is_next_link_available(driver),
prev=is_prev_link_available(driver),
count=len(rows), names=[names[0].text])
count=len(names), names=[names[0].text])
return actual_table
def get_image_table_definition(driver, sorting=False):
"""This function is specific to Image table definition"""
names = driver.find_elements_by_css_selector("td[class='rsp-p1 word-wrap']")
if sorting:
names.sort()
actual_table = TableDefinition(next=is_next_link_available(driver),
prev=is_prev_link_available(driver),
count=len(names), names=[names[0].text])
return actual_table